Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12;
Date: Tue, 3 Nov 2015 19:41:23 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Anchal Jain <anchalj109@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: lustre: lnet: Remove an else
 after an if-return
Message-ID: <20151104034123.GC29832@kroah.com>
References: <20151101142932.GA12081@anchal-VirtualBox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151101142932.GA12081@anchal-VirtualBox>
User-Agent: Mutt/1.5.24 (2015-08-30)

On Sun, Nov 01, 2015 at 07:59:32PM +0530, Anchal Jain wrote:
> The original motivation of the patch was to remove an 
> else after an if branch that ends in a return. This 
> removal required the removal of a list of other things. 
> That are needed to make the code either correct or 
> acceptable to checkpatch, for example:removing a blank 
> line, removing braces, etc.
> 
> Remove unnecessary use of else that required the
> removal of corresponding braces. And then the
> declaration of hash was movedup to the beginning of the
> function is required, but the initialization was left
> where it was. And it also required remove the blank
> line and add some new lines before the if and below the
> declaration of hash.
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> 
> ---
>  drivers/staging/lustre/lnet/lnet/lib-ptl.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
> index b4f573a..aec06f9 100644
> --- a/drivers/staging/lustre/lnet/lnet/lib-ptl.c
> +++ b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
> @@ -357,16 +357,14 @@ lnet_mt_match_head(struct lnet_match_table *mtable,
>  		   lnet_process_id_t id, __u64 mbits)
>  {
>  	struct lnet_portal *ptl = the_lnet.ln_portals[mtable->mt_portal];
> -
> -	if (lnet_ptl_is_wildcard(ptl)) {
> +	 unsigned long hash;

Very odd indentation :(