From: Marek Vasut Date: Mon, 9 Nov 2015 16:21:00 +0100 Subject: [U-Boot] [PATCH v2] usb:ci_udc: Remove ULPI setting for i.MX OTG controller In-Reply-To: <5640B8D5.5080707@wwwdotorg.org> References: <1447059813-25890-1-git-send-email-B37916@freescale.com> <5640B8D5.5080707@wwwdotorg.org> Message-ID: <201511091621.00831.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, November 09, 2015 at 04:16:37 PM, Stephen Warren wrote: > On 11/09/2015 02:03 AM, Ye.Li wrote: > > All the i.MX6, i.MX23 and i.MX28 OTG controllers only support UTMI > > interface. Set to ULPI is not correct, even the controller will reject > > this setting in PORTSC register. > > > > diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c > > > > @@ -1018,18 +1018,10 @@ int usb_gadget_register_driver(struct > > usb_gadget_driver *driver) > > > > return ret; > > > > ret = ci_udc_probe(); > > ... > > > + if (ret) { > > + DBG("udc probe failed, returned %d\n", ret); > > + return ret; > > > > } > > The indentation of the "if" line is incorrect. I'm also not quite fond of the DBG() statement, why not change it to plain debug() ? Best regards, Marek Vasut