Received: from eggs.gnu.org ([2001:4830:134:3::10]:35114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwTWb-0002iu-8e for qemu-devel@nongnu.org; Wed, 11 Nov 2015 06:25:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwTWX-0000Gw-WC for qemu-devel@nongnu.org; Wed, 11 Nov 2015 06:25:13 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:47320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwTWX-0000G4-Mq for qemu-devel@nongnu.org; Wed, 11 Nov 2015 06:25:09 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Nov 2015 11:25:07 -0000 Date: Wed, 11 Nov 2015 12:25:03 +0100 From: Cornelia Huck Message-ID: <20151111122503.1e445227.cornelia.huck@de.ibm.com> In-Reply-To: <1447186571-27672-4-git-send-email-thuth@redhat.com> References: <1447186571-27672-1-git-send-email-thuth@redhat.com> <1447186571-27672-4-git-send-email-thuth@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-trivial@nongnu.org, Christian Borntraeger , Richard Henderson , qemu-devel@nongnu.org, Alexander Graf On Tue, 10 Nov 2015 21:16:10 +0100 Thomas Huth wrote: > The "return;" statements at the end of functions do not make > much sense, so let's remove them. > > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Thomas Huth > --- > hw/s390x/css.c | 1 - > hw/s390x/event-facility.c | 21 ++++++--------------- > hw/s390x/s390-pci-bus.c | 4 ---- > 3 files changed, 6 insertions(+), 20 deletions(-) > Ack for the css and pci parts. The sclp parts, however, switch from "one point of exit" to "immediate exit", and I'm not sure I like that; not sure enough anyway to apply this patch.