From: Tom Rini Date: Fri, 13 Nov 2015 09:06:45 -0500 Subject: [U-Boot] [PATCH V2 07/12] board: LaCie: Move common headers to board-common directory In-Reply-To: <20151113103043.GT4665@kw.sim.vm.gnt> References: <1447393422-4169-1-git-send-email-nm@ti.com> <1447393422-4169-8-git-send-email-nm@ti.com> <20151113103043.GT4665@kw.sim.vm.gnt> Message-ID: <20151113140645.GK8060@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Nov 13, 2015 at 11:30:43AM +0100, Simon Guinot wrote: > Hi Nishanth, > > On Thu, Nov 12, 2015 at 11:43:37PM -0600, Nishanth Menon wrote: > > Header files can be located in a generic location without > > needing to reference them with ../common/ > > > > Generated with the following script > > > > #!/bin/bash > > vendor=board/LaCie > > common=$vendor/common > > > > cfiles=`git grep "../common" $vendor|grep "#include"|cut -d '"' -f2|sort -u|grep c$` > > headers=`git grep "../common" $vendor|grep "#include"|cut -d '"' -f2|sort -u|grep h$` > > > > mkdir -p $common/include/board-common > > set -x > > for header in $headers > > do > > echo "processing $header in $common" > > hbase=`basename $header` > > git mv $common/$hbase $common/include/board-common > > sed -i -e "s/\"..\/common\/$hbase\"//g" $vendor/*/*.[chS] > > sed -i -e "s/\"$hbase\"//g" $vendor/common/*.[chS] > > done > > > > Cc: Simon Guinot > > Cc: Albert ARIBAUD > > > > Signed-off-by: Nishanth Menon > > --- > > board/LaCie/common/cpld-gpio-bus.c | 2 +- > > board/LaCie/common/{ => include/board-common}/common.h | 0 > > Is that really a good idea to move a LaCie-specific file named common.h > to a place shared with other boards ? > > > board/LaCie/common/{ => include/board-common}/cpld-gpio-bus.h | 0 > > IMO, this headers are specific to LaCie boards and it don't make much > sense to move them to a shared place. Moreover it is quite convenient to > have them close from the board setup files. > > Please don't move them. Please read and then suggest changes in the "Makefile: Include vendor common library in include search path" thread. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: