From: Tom Rini Date: Wed, 18 Nov 2015 17:37:29 -0500 Subject: [U-Boot] [U-Boot, 1/2] test: fat: add error-checking to non-contig test In-Reply-To: <1447781348-22007-1-git-send-email-swarren@wwwdotorg.org> References: <1447781348-22007-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <20151118223729.GX8060@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Nov 17, 2015 at 10:29:07AM -0700, Stephen Warren wrote: > From: Stephen Warren > > Check the result code of all command that are executed. Without this, > if the fallocate invocation fails (this feature is not supported on ext3 > filesystems for example) then a zero-length output file will be created, > and subsequent the mkfs and mount invocations will fail, which will cause > the subsequent dd invocation to attempt to fill up the host's entire free > disk space. That's not a nice user experience! > > Related, if fallocate does fail, try to create the test disk image using > dd instead. That should work everywhere. > > Fixes: 4a28274227d0 ("test: fat: add test of non-contiguous file reads") > Signed-off-by: Stephen Warren Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: