Received: from eggs.gnu.org ([2001:4830:134:3::10]:50985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzmXf-00059n-9E for qemu-devel@nongnu.org; Fri, 20 Nov 2015 09:20:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzmXc-0006BQ-5v for qemu-devel@nongnu.org; Fri, 20 Nov 2015 09:19:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzmXc-0006Aw-0f for qemu-devel@nongnu.org; Fri, 20 Nov 2015 09:19:56 -0500 Date: Fri, 20 Nov 2015 12:19:50 -0200 From: Eduardo Habkost Message-ID: <20151120141950.GI23717@thinpad.lan.raisama.net> References: <1448024440-31222-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448024440-31222-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: hutao@cn.fujitsu.com, qemu-devel@nongnu.org, mst@redhat.com On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: > qmp_query_memdev() doesn't fail. Instead, it returns an empty list. > That's wrong. > > Two error paths: > > * When object_get_objects_root() returns null. It never does, so > simply drop the useless error handling. > > * When query_memdev() fails. This can happen, and the error to return > is the one that query_memdev() currently leaks. Passing the error > from query_memdev() to qmp_query_memdev() isn't so simple, because > object_child_foreach() is in the way. Fixable, but I'd rather not > try it in hard freeze. Plug the leak, make up an error, and add a > FIXME for the remaining work. > > Screwed up in commit 76b5d85 "qmp: add query-memdev". > > Signed-off-by: Markus Armbruster Reviewed-by: Eduardo Habkost Do you know how to trigger a query_memdev() error today, or is just theoretical? -- Eduardo