Return-Path: Received: from mail-yk0-f175.google.com ([209.85.160.175]:36580 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758006AbbKTVXd (ORCPT ); Fri, 20 Nov 2015 16:23:33 -0500 Received: by ykdr82 with SMTP id r82so178887737ykd.3 for ; Fri, 20 Nov 2015 13:23:32 -0800 (PST) Date: Fri, 20 Nov 2015 16:23:29 -0500 From: Tejun Heo To: Ilya Dryomov Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] block: detach bdev inode from its wb in __blkdev_put() Message-ID: <20151120212329.GF1574@mtj.duckdns.org> References: <1448054554-24138-1-git-send-email-idryomov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448054554-24138-1-git-send-email-idryomov@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 20, 2015 at 10:22:34PM +0100, Ilya Dryomov wrote: > Since 52ebea749aae ("writeback: make backing_dev_info host > cgroup-specific bdi_writebacks") inode, at some point in its lifetime, > gets attached to a wb (struct bdi_writeback). Detaching happens on > evict, in inode_detach_wb() called from __destroy_inode(), and involves > updating wb. > > However, detaching an internal bdev inode from its wb in > __destroy_inode() is too late. Its bdi and by extension root wb are > embedded into struct request_queue, which has different lifetime rules > and can be freed long before the final bdput() is called (can be from > __fput() of a corresponding /dev inode, through dput() - evict() - > bd_forget(). bdevs hold onto the underlying disk/queue pair only while > opened; as soon as bdev is closed all bets are off. In fact, > disk/queue can be gone before __blkdev_put() even returns: > > 1499 static void __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part) > 1500 { > ... > 1518 if (bdev->bd_contains == bdev) { > 1519 if (disk->fops->release) > 1520 disk->fops->release(disk, mode); > > [ Driver puts its references to disk/queue ] > > 1521 } > 1522 if (!bdev->bd_openers) { > 1523 struct module *owner = disk->fops->owner; > 1524 > 1525 disk_put_part(bdev->bd_part); > 1526 bdev->bd_part = NULL; > 1527 bdev->bd_disk = NULL; > 1528 if (bdev != bdev->bd_contains) > 1529 victim = bdev->bd_contains; > 1530 bdev->bd_contains = NULL; > 1531 > 1532 put_disk(disk); > > [ We put ours, the queue is gone > The last bdput() would result in a write to invalid memory ] > > 1533 module_put(owner); > ... > 1539 } > > Since bdev inodes are special anyway, detach them in __blkdev_put() > after clearing inode's dirty bits, turning the problematic > inode_detach_wb() in __destroy_inode() into a noop. > > add_disk() grabs its disk->queue since 523e1d399ce0 ("block: make > gendisk hold a reference to its queue"), so the old ->release comment > is removed in favor of the new inode_detach_wb() comment. > > Cc: stable@vger.kernel.org # 4.2+, needs backporting > Signed-off-by: Ilya Dryomov Acked-by: Tejun Heo Thanks. -- tejun