From: David Gibson Subject: Re: [PATCH] KVM: PPC: Fix emulation of H_SET_DABR/X on POWER8 Date: Mon, 23 Nov 2015 12:35:28 +1100 Message-ID: <20151123123528.25083d09@voom.fritz.box> References: <1448007105-15283-1-git-send-email-thuth@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/3bzh5RXc5S/p0/C.s0rwegk"; protocol="application/pgp-signature" Cc: kvm-ppc@vger.kernel.org, Paul Mackerras , lvivier@redhat.com, kvm@vger.kernel.org To: Thomas Huth Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56723 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953AbbKWBfH (ORCPT ); Sun, 22 Nov 2015 20:35:07 -0500 In-Reply-To: <1448007105-15283-1-git-send-email-thuth@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: --Sig_/3bzh5RXc5S/p0/C.s0rwegk Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 20 Nov 2015 09:11:45 +0100 Thomas Huth wrote: > In the old DABR register, the BT (Breakpoint Translation) bit > is bit number 61. In the new DAWRX register, the WT (Watchpoint > Translation) bit is bit number 59. So to move the DABR-BT bit > into the position of the DAWRX-WT bit, it has to be shifted by > two, not only by one. This fixes hardware watchpoints in gdb of > older guests that only use the H_SET_DABR/X interface instead > of the new H_SET_MODE interface. >=20 > Signed-off-by: Thomas Huth Reviewed-by: David Gibson Reviewed-by: David Gibson > --- > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/b= ook3s_hv_rmhandlers.S > index b98889e..3983b87 100644 > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > @@ -2143,7 +2143,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S) > =20 > /* Emulate H_SET_DABR/X on P8 for the sake of compat mode guests */ > 2: rlwimi r5, r4, 5, DAWRX_DR | DAWRX_DW > - rlwimi r5, r4, 1, DAWRX_WT > + rlwimi r5, r4, 2, DAWRX_WT > clrrdi r4, r4, 3 > std r4, VCPU_DAWR(r3) > std r5, VCPU_DAWRX(r3) > --=20 > 1.8.3.1 >=20 --=20 David Gibson Senior Software Engineer, Virtualization, Red Hat --Sig_/3bzh5RXc5S/p0/C.s0rwegk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWUm1gAAoJEGw4ysog2bOS8qUP/A4zgA47p+S42T66DBXrLAm6 Tt83gv9lp25b2es/EvC1P0EOJTq7dThuwixzAn20zgKblqjlUu7JEK8ps8DGzODn 4b6d1X6uU+8wjpKcQKKPO7DLgM2Naj9rC5MGfDphjaNy8GxM4K/PmaH93TosPS0h PbhEUFg+oS6KKbY+RXYiu8wixYfacmsUp4zwqu3vqdZWq1RNSf3IbLxaSlvZhaV1 4+J4JgUz95JbUwYaHlSZt6rm/3oZmPtCEFc6IXmi+og1wVQebMEGXE+SS+9rgpqJ RPNHgeMKqAeKPaFX1Cy0YCxHL8dYfRf6poMBzQUo+kX89aYhcVxVWCVJitw7KLqi nglNvS6ubTm24gAqFavtmSVandwwjYLhUfIlnsTsf3PKdMmtUfN31vc1zy9wS0d/ wdzn/GwtEs0X5fvzrmru4jQ04UWeg+xG5IFLe07pYBRPPVGXyotVFm2/tdSiCGTd hQ/mFHs3/+3HTmcaZ69Lz+qpBNExV/tYt1KPE6ukCRZ59pAK6mtLm24Ut1f8NSE2 BSR7OXvw93ZPjE0FWqzX+3ACgm1xMBaPXQrcb9+cv9XEuQGBZr5VaVBe+DtUeGPF czEh/oZqSiUrqg+pc8I84xZirjSU2pztLRfwor5m8TOmn18hD0G+s8V6mi4wftFz yku2P2NLF2suL1lvrRQq =Tesd -----END PGP SIGNATURE----- --Sig_/3bzh5RXc5S/p0/C.s0rwegk--