Return-Path: Received: from mail-yk0-f178.google.com ([209.85.160.178]:34165 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754960AbbKWPgK (ORCPT ); Mon, 23 Nov 2015 10:36:10 -0500 Received: by ykfs79 with SMTP id s79so242303134ykf.1 for ; Mon, 23 Nov 2015 07:36:10 -0800 (PST) Date: Mon, 23 Nov 2015 10:35:52 -0500 From: Tejun Heo To: Christoph Hellwig Cc: Ilya Dryomov , Alexander Viro , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] block: detach bdev inode from its wb in __blkdev_put() Message-ID: <20151123153552.GA3049@mtj.duckdns.org> References: <1448054554-24138-1-git-send-email-idryomov@gmail.com> <20151122150216.GA15716@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151122150216.GA15716@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hello, Christoph. On Sun, Nov 22, 2015 at 04:02:16PM +0100, Christoph Hellwig wrote: > The right fix is to never point from the inode to a BDI. I fixed this > with a lot of effort, and the BDI writeback series put it back a little > later. We need to revert that damage (not neseccarily literally, but the > effect). Can you please explain a bit more why inode pointing to its associated bdi_writeback is a bad idea? The only alternative would be recording a key and looking up each time. We sure can do that but I don't get why we would want to. Thanks. -- tejun