Received: from eggs.gnu.org ([2001:4830:134:3::10]:33133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1WHc-0007hg-8y for qemu-devel@nongnu.org; Wed, 25 Nov 2015 04:22:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1WHY-0001yR-Bd for qemu-devel@nongnu.org; Wed, 25 Nov 2015 04:22:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1WHY-0001yN-6j for qemu-devel@nongnu.org; Wed, 25 Nov 2015 04:22:32 -0500 Date: Wed, 25 Nov 2015 10:22:29 +0100 From: Kevin Wolf Message-ID: <20151125092229.GA5957@noname.str.redhat.com> References: <1448393771-15483-1-git-send-email-jsnow@redhat.com> <1448393771-15483-2-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448393771-15483-2-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/1] ide-test: fix timeouts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: pl@kamp.de, qemu-devel@nongnu.org Am 24.11.2015 um 20:36 hat John Snow geschrieben: > Use explicit timeouts instead of trying to approximate it by counting > the cumulative duration of nsleep calls. > > In practice, the timeout if inb() dwarfed the nsleep delays, and as a > result the real timeout value became a lot larger than 5 seconds. > > So: change the semantics from "Not sooner than 5 seconds" to "no more > than 5 seconds" to ensure we don't hang the tester for very long. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf