Received: from eggs.gnu.org ([2001:4830:134:3::10]:60218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Q3L-0006Vw-G4 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 10:07:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3Q3F-000645-Ot for qemu-devel@nongnu.org; Mon, 30 Nov 2015 10:07:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Q3F-000641-JQ for qemu-devel@nongnu.org; Mon, 30 Nov 2015 10:07:37 -0500 Date: Mon, 30 Nov 2015 13:07:33 -0200 From: Eduardo Habkost Message-ID: <20151130150733.GG23717@thinpad.lan.raisama.net> References: <1448553628-5446-1-git-send-email-marcel@redhat.com> <1448553628-5446-4-git-send-email-marcel@redhat.com> <20151127172852.GZ23717@thinpad.lan.raisama.net> <565ABB4B.9080703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565ABB4B.9080703@redhat.com> Subject: Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, kraxel@redhat.com, laine@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, lersek@redhat.com, rth@twiddle.net On Sun, Nov 29, 2015 at 10:46:03AM +0200, Marcel Apfelbaum wrote: > On 11/27/2015 07:28 PM, Eduardo Habkost wrote: > >On Thu, Nov 26, 2015 at 06:00:28PM +0200, Marcel Apfelbaum wrote: > >>Add bus property to PC machines and use it when looking > >>for primary PCI root bus (bus 0). > >> > >>Signed-off-by: Marcel Apfelbaum > > > >I can't pretend I have reviewed the q35 part, but the changes are > >an improvement to the existing code that depended on > >find_i440fx(). > > > >Acked-by: Eduardo Habkost > > Thanks! > > > > >BTW, what's missing to allow us to change acpi_set_pci_info() to > >use PCMachine::bus instead of find_i440fx(), too? How much of the > >PCI hotplug stuff is different in q35? > > It is pretty different. > i440fx has acpi based hotplug while q35 has PCIe native hotplug. Since is > "native", no acpi info is necessary. > > Having said that, if we have an PCIe-PCI bridge, the pci devices behind it > cannot be hotplugged/unplugged right now. > > Once we decide to add hotplug support for this scenario, maybe we can get rid of > find_i440fx(). Thanks for the explanation. I wonder if there's a better way to check if ACPI-based hotplug is needed by looking at PCMachineState or PCIBus, so we don't couple the ACPI code to piix.c. -- Eduardo