From: Tom Rini Date: Mon, 7 Dec 2015 14:06:26 -0500 Subject: [U-Boot] [PATCH] mkimage: Fix generating multi and script images again In-Reply-To: <1449507714-9599-1-git-send-email-marex@denx.de> References: <1449507714-9599-1-git-send-email-marex@denx.de> Message-ID: <20151207190626.GP9551@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Dec 07, 2015 at 06:01:54PM +0100, Marek Vasut wrote: > Seems 6ae6e160 broke creating multi and script type images and even > building of mkimage itself. There are two problems with that patch. > > First is that expression (!(x == 0) || !(x == 1)) is always true for > unsigned int x. The expression must use AND (&&) not OR (||) to be > correct. > > Second is the coding which causes gcc 4.9.x and newer scream gruesome > death and murder. The expression !x == 0 && !x == 1 is ambiguous and > should instead be rewritten into (x != 0) && (x != 1) to be correct. > The parenthesis are added for clarity. > > Signed-off-by: Marek Vasut > Cc: Tom Rini > Cc: Philippe De Swert > Cc: Simon Glass After rewording the commit message a bit (and talking with Marek on IRC about my reword), applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: