From: Martin Jansa <martin.jansa@gmail.com>
Date: Fri, 11 Dec 2015 14:55:21 +0100
To: openembedded-devel@lists.openembedded.org
Message-ID: <20151211135521.GB2248@jama>
References: <cover.1448012203.git.liezhi.yang@windriver.com>
	<b32062fe5fc0dc3c7124a9957693964fa99e7693.1448012203.git.liezhi.yang@windriver.com>
MIME-Version: 1.0
In-Reply-To: <b32062fe5fc0dc3c7124a9957693964fa99e7693.1448012203.git.liezhi.yang@windriver.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [PATCH 5/7] ctdb: RDEPENDS on bash
Precedence: list
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Yylu36WmvOXNoKYn"
Content-Disposition: inline

--Yylu36WmvOXNoKYn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 20, 2015 at 02:05:12AM -0800, Robert Yang wrote:
> Fixed:
> ctdb-2.5.1: /usr/bin/onnode_ctdb contained in package ctdb requires /bin/=
bash, but no providers found in its RDEPENDS [file-rdeps]

There is patch for this from kergoth already.

>=20
> And really bashisms there:
> $ checkbashisms usr/bin/onnode
> possible bashism in tmp/work/corei7-64-wrs-linux/ctdb/2.5.1-r0/image/usr/=
bin/onnode line 186 (<<< here string):
>         done <<<"$ctdb_status_output"
> possible bashism in tmp/work/corei7-64-wrs-linux/ctdb/2.5.1-r0/image/usr/=
bin/onnode line 250 (<<< here string):
>     done <<<"$out"
> possible bashism in tmp/work/corei7-64-wrs-linux/ctdb/2.5.1-r0/image/usr/=
bin/onnode line 284 (${parm/?/pat[/str]}):
>                 echo "${all_nodes//#DEAD/}"
> possible bashism in tmp/work/corei7-64-wrs-linux/ctdb/2.5.1-r0/image/usr/=
bin/onnode line 337 (${parm/?/pat[/str]}):
>=20
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta-networking/recipes-support/ctdb/ctdb_2.5.1.bb |    1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/meta-networking/recipes-support/ctdb/ctdb_2.5.1.bb b/meta-ne=
tworking/recipes-support/ctdb/ctdb_2.5.1.bb
> index 3731efd..70bdfb1 100644
> --- a/meta-networking/recipes-support/ctdb/ctdb_2.5.1.bb
> +++ b/meta-networking/recipes-support/ctdb/ctdb_2.5.1.bb
> @@ -27,6 +27,7 @@ inherit autotools-brokensep pkgconfig systemd
>  PARALLEL_MAKE =3D ""
> =20
>  DEPENDS +=3D "popt libtevent talloc"
> +RDEPENDS_${PN} +=3D "bash"
> =20
>  do_configure() {
>      oe_runconf
> --=20
> 1.7.9.5
>=20
> --=20
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--=20
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

--Yylu36WmvOXNoKYn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlZq1cgACgkQN1Ujt2V2gBxdawCfV7iZcxc6SpLvSyGT7xMJDtUa
4rMAoJzpbi/mGeEvDk5YSjUgfOd5qv1z
=Zbqu
-----END PGP SIGNATURE-----

--Yylu36WmvOXNoKYn--