Received: from eggs.gnu.org ([2001:4830:134:3::10]:44834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9xSL-0007Id-BT for qemu-devel@nongnu.org; Fri, 18 Dec 2015 11:00:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9xSF-0000lq-Mz for qemu-devel@nongnu.org; Fri, 18 Dec 2015 11:00:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9xSF-0000lJ-Hg for qemu-devel@nongnu.org; Fri, 18 Dec 2015 11:00:27 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1B673A4540 for ; Fri, 18 Dec 2015 16:00:27 +0000 (UTC) Date: Fri, 18 Dec 2015 14:00:23 -0200 From: Eduardo Habkost Message-ID: <20151218160023.GA1724@thinpad.lan.raisama.net> References: <1448267731-32678-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448267731-32678-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mst@redhat.com On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote: > qmp_query_memdev() has two error paths: > > * When object_get_objects_root() returns null. It never does, so > simply drop the useless error handling. > > * When query_memdev() fails. It leaks err then. But any failure > there is actually a programming error. Switch it to &error_abort, > and drop the useless error handling. > > Messed up in commit 76b5d85 "qmp: add query-memdev". > > Signed-off-by: Markus Armbruster Reviewed-by: Eduardo Habkost Applied to the numa tree. Thanks! -- Eduardo