Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Brian Norris , "Stephen Boyd" From: Michael Turquette In-Reply-To: <1450290903-24470-1-git-send-email-computersforpeace@gmail.com> Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, "Brian Norris" , "Jyri Sarha" , "Sergej Sawazki" References: <1450290511-14442-1-git-send-email-computersforpeace@gmail.com> <1450290903-24470-1-git-send-email-computersforpeace@gmail.com> Message-ID: <20160101055708.21738.66909@quark.deferred.io> Subject: Re: [PATCH] clk: gpio: handle error codes for of_clk_get_parent_count() Date: Thu, 31 Dec 2015 21:57:08 -0800 List-ID: Quoting Brian Norris (2015-12-16 10:35:03) > We might make bad memory allocations if we get (e.g.) -ENOSYS from > of_clk_get_parent_count(). > = > Noticed by Coverity. > = > Fixes: f66541ba02d5 ("clk: gpio: Get parent clk names in of_gpio_clk_setu= p()") > Signed-off-by: Brian Norris > Cc: Jyri Sarha > Cc: Sergej Sawazki > Cc: Stephen Boyd Thanks for the fix. Applied. Regards, Mike > --- > Sorry, I noticed Coverity was complaining about 1 more. > = > drivers/clk/clk-gpio.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > = > diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c > index c1baa89cbf91..1767b9e3ca93 100644 > --- a/drivers/clk/clk-gpio.c > +++ b/drivers/clk/clk-gpio.c > @@ -287,12 +287,14 @@ static void __init of_gpio_clk_setup(struct device_= node *node, > const char **parent_names; > int i, num_parents; > = > + num_parents =3D of_clk_get_parent_count(node); > + if (num_parents < 0) > + return; > + > data =3D kzalloc(sizeof(*data), GFP_KERNEL); > if (!data) > return; > = > - num_parents =3D of_clk_get_parent_count(node); > - > parent_names =3D kcalloc(num_parents, sizeof(char *), GFP_KERNEL); > if (!parent_names) { > kfree(data); > -- = > 2.6.0.rc2.230.g3dd15c0 >=20