From: horms@verge.net.au (Simon Horman) Date: Mon, 4 Jan 2016 08:07:07 +1100 Subject: [PATCH] ARM: shmobile: alt: Add QSPI device to DT In-Reply-To: References: <1448863990-16276-1-git-send-email-horms+renesas@verge.net.au> <20151201064149.GH16260@verge.net.au> <20151218025410.GA10973@verge.net.au> Message-ID: <20160103210707.GC22806@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Dec 18, 2015 at 11:07:23AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman wrote: > > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: > >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman wrote: > >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > >> >> wrote: > >> >> > Enable the QSPI controller in the alt device tree. > >> >> > > >> >> > Based similar work for the silk board by by Vladimir Barinov and > >> >> > Sergei Shtylyov. > >> >> > > >> >> > Cc: Vladimir Barinov > >> >> > Cc: Sergei Shtylyov > >> >> > Signed-off-by: Simon Horman > >> >> > >> >> Verified against Alt schematics and r8a7794 datasheet. > >> >> > >> >> Acked-by: Geert Uytterhoeven > >> >> > >> >> I can't verify the FLASH layout. Note that p.11 of > >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > >> >> FLASH layout for the second and third partition. > >> > > >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > >> > the same as the document you referred to above? > >> > > >> > > >> > partition at 0 { > >> > label = "loader"; > >> > reg = <0x00000000 0x00080000>; > >> > read-only; > >> > }; > >> > partition at 40000 { > >> > label = "user"; > >> > reg = <0x00080000 0x00580000>; > >> > read-only; > >> > }; > >> > partition at 440000 { > >> > label = "flash"; > >> > reg = <0x00600000 0x03a00000>; > >> > }; > >> > > >> > > >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 > >> > >> No, the document specifies 3 partitions: > >> - SA0: loader program area, 16 KiB, > > Sorry, I missed a "Not used" part after that, and started miscounting zeroes > on top of that :-( > > So the loader consumes 16 KiB out of the 256 KiB SA0 partition. > > >> - SA1: System area, 16 KiB, > > Should be 256 KiB. > > >> - SA2: User program area, remainder. > >> > >> FWIW, the unit addresses in the device nodes above are not consistent > >> with their reg properties. > > > > My feeling is that we should follow the documentation. > > Does this reflect the scheme it describes? > > > > > > partitions { > > #address-cells = <1>; > > #size-cells = <1>; > > > > partition at 0 { > > label = "loader"; > > reg = <0x00000000 0x00004000>; > > reg = <0x00000000 0x00040000>; > > > read-only; > > }; > > partition at 4000 { > > partition at 40000 > > > label = "system"; > > reg = <0x00004000 0x00004000>; > > reg = <0x00040000 0x00040000>; > > > read-only; > > }; > > partition at 8000 { > > partition at 80000 > > > label = "user"; > > reg = <0x00008000 0x03ff8000>; > > reg = <0x00080000 0x03f80000>; > > > }; > > }; > > I don't have an ALT. Does this match with the actual FLASH contents? I'm a little unsure how to verify that. > Sorry for the wreck on my side. No problem.