From: Tom Rini Date: Mon, 4 Jan 2016 10:51:09 -0500 Subject: [U-Boot] [PATCH 4/4] rapidio: add driver for TI KeyStone RapidIO In-Reply-To: <1447157633-3757-1-git-send-email-jacquiot.aurelien@gmail.com> References: <1447157633-3757-1-git-send-email-jacquiot.aurelien@gmail.com> Message-ID: <20160104155109.GK4093@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Nov 10, 2015 at 01:13:53PM +0100, jacquiot.aurelien at gmail.com wrote: > From: Aurelien Jacquiot > > This commit includes the KeyStone device driver for RapidIO > allowing to use the RapidIO boot functionality. > > Today only K2HK devices have RapidIO support. > > Signed-off-by: Aurelien Jacquiot [snip] > +#define debug_rio(fmt, args...) if (rio_dbg) printf(fmt, ##args) Please use the normal debug() macro here. [snip] > + if (count >= KEYSTONE_RIO_TIMEOUT_CNT) { > + debug_rio( > + "RIO: timeout %d, ltid = %d, context = %d, lcb = %d, cc = %d\n", > + count, ltid, context, lcb, status); Here and elsewhere we have a bit of a funny line-break. It's OK to do: debug("String that exceeds 80 char wide\n", align, all, variables, on, other, lines); -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: