From: Tom Rini <trini@konsulko.com>
Date: Mon, 4 Jan 2016 11:22:04 -0500
Subject: [U-Boot] [PATCH] cmd_pci: Check for VendorID earlier
In-Reply-To: <CAEUhbmXw_+5eKsx6rPbjfUnrg3+OzzJycACG5dRTyaizxFJz=w@mail.gmail.com>
References: <CAPnjgZ3OhN1zS8tY8xFbaWVLAhZhk38WXt5BSdnTT1T7u=d1HA@mail.gmail.com>
 <CAOMZO5AiiQhOjtEMBTEgHXB6gTQ1vFZ_eDhW5yf8UuOe92Az=w@mail.gmail.com>
 <CAPnjgZ2spXKBUBRnWYPxc46vQP_AnFRnkBvfTsUnmL=BXrf3jg@mail.gmail.com>
 <CAOMZO5D+WHX8qSxn8K21oPawERPPkg9q7m12Lw5N7VK7ajTjFg@mail.gmail.com>
 <CAPnjgZ1kU0gFGNak4f6DDcQjkWiLS8tWBgGhVmJTd0u4M6Kcnw@mail.gmail.com>
 <CAOMZO5CRrfDricumFn1r=DGUz8Pkw4O6uHC6GTNvyCMpFTJQMw@mail.gmail.com>
 <CAPnjgZ2N4Q-y0LjnYW94MX9AyWPPisi0ueiWOmfEWp98N3Duzw@mail.gmail.com>
 <CAEUhbmVW0LK13O4rpvomn6m02e-ijwfXhpypPFRxEUa-CoWa8w@mail.gmail.com>
 <CAOMZO5B_JSAnxQ8mAhws2hb=eSWVjo_jeRw25XbtWRCF78PuEg@mail.gmail.com>
 <CAEUhbmXw_+5eKsx6rPbjfUnrg3+OzzJycACG5dRTyaizxFJz=w@mail.gmail.com>
Message-ID: <20160104162204.GO4093@bill-the-cat>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Jan 04, 2016 at 11:11:18AM +0800, Bin Meng wrote:
> Hi Fabio,
> 
> On Thu, Dec 31, 2015 at 11:20 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > Hi Bin,
> >
> > On Thu, Dec 31, 2015 at 7:32 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> >> I also see this behavior on ls1021atwr board. I agree with Simon, the
> >> correct fix should fix the PCIe driver to return 0 instead of -EINVAL.
> >
> > Do you mean like this for imx?
> >
> 
> Yes
> 
> > --- a/drivers/pci/pcie_imx.c
> > +++ b/drivers/pci/pcie_imx.c
> > @@ -381,7 +381,7 @@ static int imx_pcie_read_config(struct pci_controller *hose,
> >         ret = imx_pcie_addr_valid(d);
> >         if (ret) {
> >                 *val = 0xffffffff;
> > -               return ret;
> > +               return 0;
> >         }
> >
> >         va_address = get_bus_address(d, where);
> >
> > and like this for layerscape:
> >
> 
> Yes
> 
> > --- a/drivers/pci/pcie_layerscape.c
> > +++ b/drivers/pci/pcie_layerscape.c
> > @@ -314,7 +314,7 @@ static int ls_pcie_read_config(struct pci_controller *hose,
> >
> >         if (ls_pcie_addr_valid(hose, d)) {
> >                 *val = 0xffffffff;
> > -               return -EINVAL;
> > +               return 0;
> >         }
> >
> >         if (PCI_BUS(d) == hose->first_busno)
> >
> 
> Again, I was wondering why we created two drivers for the same (or
> similar) PCIe IPs.

Something to consolidate for the next release it sounds like.  However
we need this fixed this release yes?  Can I get a v2 of this patch with
a proper commit message?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160104/2a680133/attachment.sig>