From: Mark Brown Subject: Re: [PATCH v3 7/8] ASoC: wm_adsp: Add a handler for the compressed IRQ Date: Tue, 5 Jan 2016 16:10:58 +0000 Message-ID: <20160105161058.GF6588@sirena.org.uk> References: <1450178989-8749-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1450178989-8749-8-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20151223001907.GI16023@sirena.org.uk> <20151223095806.GY6058@localhost.localdomain> <20151224193137.GI579@sirena.org.uk> <20151229154313.GA1490@localhost.localdomain> <20160105142025.GA6588@sirena.org.uk> <20160105143636.GB1490@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1798860086635509848==" Return-path: Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 42B6B2612D0 for ; Tue, 5 Jan 2016 17:11:11 +0100 (CET) In-Reply-To: <20160105143636.GB1490@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Charles Keepax Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com, patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com, tiwai@suse.com List-Id: alsa-devel@alsa-project.org --===============1798860086635509848== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/aVve/J9H4Wl5yVO" Content-Disposition: inline --/aVve/J9H4Wl5yVO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 05, 2016 at 02:36:36PM +0000, Charles Keepax wrote: > On Tue, Jan 05, 2016 at 02:20:25PM +0000, Mark Brown wrote: > > That's not an interrupt acknowlegement, it's a request for more data. > Well a request to let us know about there being more data. We will > keep consuming data as it is generated until we reach a point where > we have less than one fragment, then we set this and wait for an > IRQ to say we have more than a fragment again. Whatever it is it's not an interrupt being acknowledged, if anything it's more one being unmasked but it seems like it's probably just a general software channel. > > > I could perhaps rename the function to > > > wm_adsp_buffer_request_irq? and buf->irq_ack to buf->irq_count? > > > That might make the usage a little more clear. > > That might be a bit clearer, yes - it looks like this is a mailbox on > > the DSP that you're kicking? > Effectively you could think of it as a mailbox, I haven't looked > much at the framework but I suspect it is a little overkill for > what we want to do here. I'm not suggesting using the framework, I'm saying don't describe it as an interrupt when it's clearly not one and does things that would be bugs if it were actually an interrupt. --/aVve/J9H4Wl5yVO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWi+sRAAoJECTWi3JdVIfQzP8H/jgdo7PrJ45+zFEn4ul7DKLS iuGU2xi79vehDZspw3ml8IeA6mqi8lXs+0xMhO4YFio4Jf+S9Z1Cc5Rxz8AEdULz 4TPvLjtaDuN6twpbhVsqJpDNdCSU78Auy+jVWOIDWxEIDfhWhuinN5cVIlPRSGrJ g0B7e+VJqd3PXzEm8atTVi1Bp1wvbv5VFSUJjSpO3rwEpq17eB7tOXeQ9upk7pFE xNMZ2FX3k+9EGwSso4rhvXAMaoqo+D2eo7eAugK9/JTrF8RuTW1LxK406ZGYftuq pY0EvvscAh0kOocWFHbGtqv0KRjXrmP+urCJk6U6oZjiVQ5u5QSctVT7j07g+qg= =D4l+ -----END PGP SIGNATURE----- --/aVve/J9H4Wl5yVO-- --===============1798860086635509848== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1798860086635509848==--