From: Alan Subject: [PATCH] gma500: clean up an excessive and confusing helper Date: Fri, 29 Jan 2016 19:37:48 +0000 Message-ID: <20160129193731.8475.47809.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lxorguk.ukuu.org.uk (lxorguk.ukuu.org.uk [81.2.110.251]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CDBD6E0B2 for ; Fri, 29 Jan 2016 11:38:07 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@linux.ie, wuninsu@gmail.com, dri-devel@lists.freedesktop.org, patrik.r.jakobsson@gmail.com, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org RnJvbTogQWxhbiBDb3ggPGFsYW5AbGludXguaW50ZWwuY29tPgoKVGhpcyBpcyBhIGxlZnQgb3Zl ciBmcm9tIHRoZSBncmVhdCBjbGVhbiB1cHMgaW4gdGhlIHBhc3QuIEl0J3MgY29uZnVzaW5nIGFz Cml0IHJldHVybnMgYW4gaW50LCB5ZXQgaGFzIG9uZSBjYWxsZXIgdGhhdCBuZXZlciB1c2VzIGl0 LiBUaGUgY2FsbGVyIGFscmVhZHkKaGFzIGFsbCB0aGUgcmlnaHQgcHJpdmF0ZSB2YXJpYWJsZXMg bG9jYWwgc28gdGhlIGVudGlyZSBmdW5jdGlvbiBjYW4gYmUKcmVwbGFjZWQgYnkgYSBzaW1wbGUg aWYgY2FsbC4KClNpZ25lZC1vZmYtYnk6IEFsYW4gQ294IDxhbGFuQGxpbnV4LmludGVsLmNvbT4K LS0tCiBkcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2ZyYW1lYnVmZmVyLmMgfCAgIDIwICsrKystLS0t LS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2ZyYW1lYnVmZmVyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2ZyYW1lYnVmZmVyLmMKaW5kZXggY2I5NTc2NS4uMDMz ZDg5NCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9mcmFtZWJ1ZmZlci5jCisr KyBiL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvZnJhbWVidWZmZXIuYwpAQCAtNjc0LDI5ICs2NzQs MTcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgcHNiX21vZGVf ZnVuY3MgPSB7CiAJLm91dHB1dF9wb2xsX2NoYW5nZWQgPSBwc2JmYl9vdXRwdXRfcG9sbF9jaGFu Z2VkLAogfTsKIAotc3RhdGljIGludCBwc2JfY3JlYXRlX2JhY2tsaWdodF9wcm9wZXJ0eShzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KQotewotCXN0cnVjdCBkcm1fcHNiX3ByaXZhdGUgKmRldl9wcml2 ID0gZGV2LT5kZXZfcHJpdmF0ZTsKLQlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpiYWNrbGlnaHQ7Ci0K LQlpZiAoZGV2X3ByaXYtPmJhY2tsaWdodF9wcm9wZXJ0eSkKLQkJcmV0dXJuIDA7Ci0KLQliYWNr bGlnaHQgPSBkcm1fcHJvcGVydHlfY3JlYXRlX3JhbmdlKGRldiwgMCwgImJhY2tsaWdodCIsIDAs IDEwMCk7Ci0KLQlkZXZfcHJpdi0+YmFja2xpZ2h0X3Byb3BlcnR5ID0gYmFja2xpZ2h0OwotCi0J cmV0dXJuIDA7Ci19Ci0KIHN0YXRpYyB2b2lkIHBzYl9zZXR1cF9vdXRwdXRzKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpCiB7CiAJc3RydWN0IGRybV9wc2JfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYt PmRldl9wcml2YXRlOwogCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7CiAKIAlkcm1f bW9kZV9jcmVhdGVfc2NhbGluZ19tb2RlX3Byb3BlcnR5KGRldik7Ci0JcHNiX2NyZWF0ZV9iYWNr bGlnaHRfcHJvcGVydHkoZGV2KTsKIAorCS8qIEl0IGlzIG9rIGZvciB0aGlzIHRvIGZhaWwgLSB3 ZSBqdXN0IGRvbid0IGdldCBiYWNrbGlnaHQgY29udHJvbCAqLworCWlmICghZGV2X3ByaXYtPmJh Y2tsaWdodF9wcm9wZXJ0eSkKKwkJZGV2X3ByaXYtPmJhY2tsaWdodF9wcm9wZXJ0eSA9IGRybV9w cm9wZXJ0eV9jcmVhdGVfcmFuZ2UoZGV2LCAwLAorCQkJCQkJCSJiYWNrbGlnaHQiLCAwLCAxMDAp OwogCWRldl9wcml2LT5vcHMtPm91dHB1dF9pbml0KGRldik7CiAKIAlsaXN0X2Zvcl9lYWNoX2Vu dHJ5KGNvbm5lY3RvciwgJmRldi0+bW9kZV9jb25maWcuY29ubmVjdG9yX2xpc3QsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=