From: Daniel Vetter Subject: Re: [PATCH] gma500: clean up an excessive and confusing helper Date: Mon, 8 Feb 2016 10:07:36 +0100 Message-ID: <20160208090736.GW11240@phenom.ffwll.local> References: <20160129193731.8475.47809.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC4266E039 for ; Mon, 8 Feb 2016 01:07:14 -0800 (PST) Received: by mail-wm0-f52.google.com with SMTP id p63so103253068wmp.1 for ; Mon, 08 Feb 2016 01:07:14 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Patrik Jakobsson Cc: Alan , linux-kernel , dri-devel , wuninsu@gmail.com List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBGZWIgMDEsIDIwMTYgYXQgMDk6MTE6NTFBTSArMDEwMCwgUGF0cmlrIEpha29ic3Nv biB3cm90ZToKPiBPbiBGcmksIEphbiAyOSwgMjAxNiBhdCA4OjM3IFBNLCBBbGFuIDxnbm9tZXNA bHhvcmd1ay51a3V1Lm9yZy51az4gd3JvdGU6Cj4gPiBGcm9tOiBBbGFuIENveCA8YWxhbkBsaW51 eC5pbnRlbC5jb20+Cj4gPgo+ID4gVGhpcyBpcyBhIGxlZnQgb3ZlciBmcm9tIHRoZSBncmVhdCBj bGVhbiB1cHMgaW4gdGhlIHBhc3QuIEl0J3MgY29uZnVzaW5nIGFzCj4gPiBpdCByZXR1cm5zIGFu IGludCwgeWV0IGhhcyBvbmUgY2FsbGVyIHRoYXQgbmV2ZXIgdXNlcyBpdC4gVGhlIGNhbGxlciBh bHJlYWR5Cj4gPiBoYXMgYWxsIHRoZSByaWdodCBwcml2YXRlIHZhcmlhYmxlcyBsb2NhbCBzbyB0 aGUgZW50aXJlIGZ1bmN0aW9uIGNhbiBiZQo+ID4gcmVwbGFjZWQgYnkgYSBzaW1wbGUgaWYgY2Fs bC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBbGFuIENveCA8YWxhbkBsaW51eC5pbnRlbC5jb20+ Cj4gCj4gU2lnbmVkLW9mZi1ieTogUGF0cmlrIEpha29ic3NvbiA8cGF0cmlrLnIuamFrb2Jzc29u QGdtYWlsLmNvbT4KCkFwcGxpZWQgdG8gZHJtLW1pc2MsIHRoYW5rcy4KLURhbmllbAoKPiAKPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9nbWE1MDAvZnJhbWVidWZmZXIuYyB8ICAgMjAgKysr Ky0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAx NiBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2dtYTUw MC9mcmFtZWJ1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9mcmFtZWJ1ZmZlci5jCj4g PiBpbmRleCBjYjk1NzY1Li4wMzNkODk0IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2dtYTUwMC9mcmFtZWJ1ZmZlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2Zy YW1lYnVmZmVyLmMKPiA+IEBAIC02NzQsMjkgKzY3NCwxNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBwc2JfbW9kZV9mdW5jcyA9IHsKPiA+ICAgICAgICAgLm91 dHB1dF9wb2xsX2NoYW5nZWQgPSBwc2JmYl9vdXRwdXRfcG9sbF9jaGFuZ2VkLAo+ID4gIH07Cj4g Pgo+ID4gLXN0YXRpYyBpbnQgcHNiX2NyZWF0ZV9iYWNrbGlnaHRfcHJvcGVydHkoc3RydWN0IGRy bV9kZXZpY2UgKmRldikKPiA+IC17Cj4gPiAtICAgICAgIHN0cnVjdCBkcm1fcHNiX3ByaXZhdGUg KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IC0gICAgICAgc3RydWN0IGRybV9wcm9w ZXJ0eSAqYmFja2xpZ2h0Owo+ID4gLQo+ID4gLSAgICAgICBpZiAoZGV2X3ByaXYtPmJhY2tsaWdo dF9wcm9wZXJ0eSkKPiA+IC0gICAgICAgICAgICAgICByZXR1cm4gMDsKPiA+IC0KPiA+IC0gICAg ICAgYmFja2xpZ2h0ID0gZHJtX3Byb3BlcnR5X2NyZWF0ZV9yYW5nZShkZXYsIDAsICJiYWNrbGln aHQiLCAwLCAxMDApOwo+ID4gLQo+ID4gLSAgICAgICBkZXZfcHJpdi0+YmFja2xpZ2h0X3Byb3Bl cnR5ID0gYmFja2xpZ2h0Owo+ID4gLQo+ID4gLSAgICAgICByZXR1cm4gMDsKPiA+IC19Cj4gPiAt Cj4gPiAgc3RhdGljIHZvaWQgcHNiX3NldHVwX291dHB1dHMoc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPiA+ICB7Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1fcHNiX3ByaXZhdGUgKmRldl9wcml2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ICAgICAgICAgc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvcjsKPiA+Cj4gPiAgICAgICAgIGRybV9tb2RlX2NyZWF0ZV9zY2FsaW5nX21vZGVfcHJvcGVy dHkoZGV2KTsKPiA+IC0gICAgICAgcHNiX2NyZWF0ZV9iYWNrbGlnaHRfcHJvcGVydHkoZGV2KTsK PiA+Cj4gPiArICAgICAgIC8qIEl0IGlzIG9rIGZvciB0aGlzIHRvIGZhaWwgLSB3ZSBqdXN0IGRv bid0IGdldCBiYWNrbGlnaHQgY29udHJvbCAqLwo+ID4gKyAgICAgICBpZiAoIWRldl9wcml2LT5i YWNrbGlnaHRfcHJvcGVydHkpCj4gPiArICAgICAgICAgICAgICAgZGV2X3ByaXYtPmJhY2tsaWdo dF9wcm9wZXJ0eSA9IGRybV9wcm9wZXJ0eV9jcmVhdGVfcmFuZ2UoZGV2LCAwLAo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiYmFja2xp Z2h0IiwgMCwgMTAwKTsKPiA+ICAgICAgICAgZGV2X3ByaXYtPm9wcy0+b3V0cHV0X2luaXQoZGV2 KTsKPiA+Cj4gPiAgICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoY29ubmVjdG9yLCAmZGV2LT5t b2RlX2NvbmZpZy5jb25uZWN0b3JfbGlzdCwKPiA+Cj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK