Received-SPF: pass (google.com: domain of amsfield22@gmail.com designates 2607:f8b0:400e:c00::242 as permitted sender) client-ip=2607:f8b0:400e:c00::242;
Date: Fri, 12 Feb 2016 10:03:55 -0800
From: Alison Schofield <amsfield22@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH v2] staging: vt6656: replace
 GFP_ATOMIC with GFP_KERNEL for urb allocation
Message-ID: <20160212180354.GA2283@d830.WORKGROUP>
References: <20160212072127.GA14416@d830.WORKGROUP>
 <1455262646-14649-1-git-send-email-amsfield22@gmail.com>
 <CAEnQRZD3vm2jfVM+j5jU3p2ya=8QxeT=Tq+fcCjsPz4U9Sx9EA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEnQRZD3vm2jfVM+j5jU3p2ya=8QxeT=Tq+fcCjsPz4U9Sx9EA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Fri, Feb 12, 2016 at 01:44:47PM +0200, Daniel Baluta wrote:
> On Fri, Feb 12, 2016 at 9:37 AM, Alison Schofield <amsfield22@gmail.com> wrote:
> > Replace one instance of GFP_ATOMIC with GFP_KERNEL during urb buffer
> > allocation.  This makes vnt_alloc_bufs() consistent in setting GFP_KERNEL
> > during kmalloc() and usb_alloc_urb(). GFP_KERNEL is safe because we are in
> > process context, not in an interrupt handler, nor holding any spinlock.
> >
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> 
> Really nice idea. While at it please also fix the allocations in the same
> function for priv->interrupt_urb and rcb->urb.

Credit goes to Julia's eagle eye!
Sending patch update.
alison

> 
> > ---
> > Changes in v2:
> > expanded abbreviations in commit message
> >
> >  drivers/staging/vt6656/main_usb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> > index 05f86ff..f7c4362 100644
> > --- a/drivers/staging/vt6656/main_usb.c
> > +++ b/drivers/staging/vt6656/main_usb.c
> > @@ -439,7 +439,7 @@ static bool vnt_alloc_bufs(struct vnt_private *priv)
> >                 tx_context->pkt_no = ii;
> >
> >                 /* allocate URBs */
> > -               tx_context->urb = usb_alloc_urb(0, GFP_ATOMIC);
> > +               tx_context->urb = usb_alloc_urb(0, GFP_KERNEL);
> >                 if (!tx_context->urb) {
> >                         dev_err(&priv->usb->dev, "alloc tx urb failed\n");
> >                         goto free_tx;
> > --
> > 2.1.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1455262646-14649-1-git-send-email-amsfield22%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.