Received-SPF: pass (google.com: domain of amsfield22@gmail.com designates 2607:f8b0:400e:c03::236 as permitted sender) client-ip=2607:f8b0:400e:c03::236;
Date: Fri, 12 Feb 2016 10:16:21 -0800
From: Alison Schofield <amsfield22@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: vt6656: move local var init
 closer to usage
Message-ID: <20160212181620.GA3391@d830.WORKGROUP>
References: <20160212070014.GA13288@d830.WORKGROUP>
 <20160212172317.GL3741@mtj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160212172317.GL3741@mtj.duckdns.org>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Fri, Feb 12, 2016 at 12:23:17PM -0500, Tejun Heo wrote:
> Hello, Alison.
> 
> On Thu, Feb 11, 2016 at 11:00:22PM -0800, Alison Schofield wrote:
> > Move init of struct urb to after sk_buf is verified otherwise
> > the init is wasted if we exit early.
> > 
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > ---
> >  drivers/staging/vt6656/usbpipe.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
> > index bec5baf..3648d16 100644
> > --- a/drivers/staging/vt6656/usbpipe.c
> > +++ b/drivers/staging/vt6656/usbpipe.c
> > @@ -209,12 +209,12 @@ int vnt_submit_rx_urb(struct vnt_private *priv, struct vnt_rcb *rcb)
> >  	int status = 0;
> >  	struct urb *urb;
> >  
> > -	urb = rcb->urb;
> >  	if (!rcb->skb) {
> >  		dev_dbg(&priv->usb->dev, "rcb->skb is null\n");
> >  		return status;
> >  	}
> >  
> > +	urb = rcb->urb;
> >  	usb_fill_bulk_urb(urb,
> >  			  priv->usb,
> >  			  usb_rcvbulkpipe(priv->usb, 2),
> 
> I'd actually go the other way and do
> 
> 	struct urb *urb = rcb->urb;
> 
> Compilers can easily optimize these orderings.  The focus should be on
> brevity and readability instead of micro optimizations which don't
> really yield anything.
> 
> Thanks.
> 
> -- 
> tejun
This was suggested to me, but I chose to mimic what another
funtion was doing in same file.  I'll change both instances
for brevity & readabiity! 
Thanks,
alison