From: Marius Vlad Subject: Re: [PATCH i-g-t] tests/prime_mmap: Encapsulate check_for_dma_buf_mmap() in igt_fixture. Date: Mon, 15 Feb 2016 11:21:30 +0200 Message-ID: <20160215092129.GA10991@mcvlad-wk.rb.intel.com> References: <1455283950-20430-1-git-send-email-marius.c.vlad@intel.com> <56BE1893.6090308@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0414407211==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 32B6D6E18D for ; Mon, 15 Feb 2016 09:34:52 +0000 (UTC) In-Reply-To: <56BE1893.6090308@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tiago Vignatti Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0414407211== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, I'm positive it does. Are you sure you've re-compiled? (check or distcheck targets do not re-compile the tests). On Fri, Feb 12, 2016 at 03:38:27PM -0200, Tiago Vignatti wrote: > I'm not sure this actually fix the root problem. With or without your pat= ch > applied, I'm seeing the following in lib/tests/test-suite.log: >=20 > ../../tests/prime_mmap: > Checking invalid option handling... > Checking valid option handling... > Checking subtest enumeration... > (prime_mmap:24023) ioctl-wrappers-CRITICAL: Test assertion failure functi= on > gem_create, file ../../lib/ioctl_wrappers.c:501: > (prime_mmap:24023) ioctl-wrappers-CRITICAL: Failed assertion: drmIoctl((f= d), > ((((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40 + 0x1b)) << = 0) > | ((((sizeof(struct drm_i915_gem_create)))) << ((0+8)+8)))), (&create)) = =3D=3D 0 > (prime_mmap:24023) ioctl-wrappers-CRITICAL: Last errno: 25, Inappropriate > ioctl for device > (prime_mmap:24023) ioctl-wrappers-CRITICAL: error: -1 !=3D 0 > Test prime_mmap failed. > **** DEBUG **** > (prime_mmap:24023) ioctl-wrappers-CRITICAL: Test assertion failure functi= on > gem_create, file ../../lib/ioctl_wrappers.c:501: > (prime_mmap:24023) ioctl-wrappers-CRITICAL: Failed assertion: drmIoctl((f= d), > ((((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40 + 0x1b)) << = 0) > | ((((sizeof(struct drm_i915_gem_create)))) << ((0+8)+8)))), (&create)) = =3D=3D 0 > (prime_mmap:24023) ioctl-wrappers-CRITICAL: Last errno: 25, Inappropriate > ioctl for device > (prime_mmap:24023) ioctl-wrappers-CRITICAL: error: -1 !=3D 0 > **** END **** > prime_mmap: ../../lib/igt_core.c:1014: igt_fail: Assertion > `!test_with_subtests || in_fixture' failed. > Received signal SIGABRT. > Aborted (core dumped) >=20 > Tiago >=20 > On 02/12/2016 11:32 AM, Marius Vlad wrote: > >This unbreaks distcheck target that in turn runs each test with --list-s= ubtests. > > > >Signed-off-by: Marius Vlad > >--- > > tests/prime_mmap.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/tests/prime_mmap.c b/tests/prime_mmap.c > >index 29a0cfd..1ea61c2 100644 > >--- a/tests/prime_mmap.c > >+++ b/tests/prime_mmap.c > >@@ -504,10 +504,10 @@ igt_main > > > > igt_fixture { > > fd =3D drm_open_driver(DRIVER_INTEL); > >+ igt_skip_on((check_for_dma_buf_mmap() !=3D 0)); > > errno =3D 0; > > } > > > >- igt_skip_on((check_for_dma_buf_mmap() !=3D 0)); > > > > for (i =3D 0; i < ARRAY_SIZE(tests); i++) { > > igt_subtest(tests[i].name) > > >=20 > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWwZiZAAoJELmLWIAQzyE+2N0H/05816x5g8sdAMxojEbZcxWz KHBtteyVt7PfTYFdHds/qr9aIp14wzgcSMumFIR8AA16ANxsZoItCQXmw+j0+IRy I/82RrMu0TrGie10dFXIWXJn3ae393X+E4lJdFt+4uDDunEjHCHTjMDZ5B1GFqwF FY3c7yNLouTSlMEPQiEa/9hLbmHUbvivqrVSIgUjob0J5qpK05ou273kJ99zA3Xc 8egeoAYxiKd+8P50VLLExFiE2Za4n6QuAWmccZ2h0xIvd17miSFKkbT12rZRjoYT lu3n6Ihs+jz3Y3aQRSJfB0a24ji5NhA/ucE42Jyiqy8T9xbEBGTpPnLwfGpjtVM= =iw/a -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o-- --===============0414407211== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0414407211==--