From: Daniel Vetter Subject: Re: [PATCH 08/12] drm/i915: ensure the HW is powered when accessing the CRC HW block Date: Tue, 16 Feb 2016 17:02:53 +0100 Message-ID: <20160216160253.GR32705@phenom.ffwll.local> References: <1455296121-4742-1-git-send-email-imre.deak@intel.com> <1455296121-4742-9-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1736289998 for ; Tue, 16 Feb 2016 16:02:28 +0000 (UTC) Received: by mail-wm0-f42.google.com with SMTP id b205so116667233wmb.1 for ; Tue, 16 Feb 2016 08:02:28 -0800 (PST) Content-Disposition: inline In-Reply-To: <1455296121-4742-9-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMTIsIDIwMTYgYXQgMDY6NTU6MTdQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IFRoZSBhc3N1bXB0aW9uIHdoZW4gYWRkaW5nIHRoZSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2lz X2VuYWJsZWQoKSBjaGVja3MKPiB3YXMgdGhhdCBpZiBpdCByZXR1cm5zIHN1Y2Nlc3MgdGhlIHBv d2VyIGNhbid0IGJlIHR1cm5lZCBvZmYgYWZ0ZXJ3YXJkcwo+IGR1cmluZyB0aGUgSFcgYWNjZXNz LCB3aGljaCBpcyBndWFyYW50ZWVkIGJ5IG1vZGVzZXQgbG9ja3MuIFRoaXMgaXNuJ3QKPiBhbHdh eXMgdHJ1ZSwgc28gbWFrZSBzdXJlIHdlIGhvbGQgYSBkZWRpY2F0ZWQgcmVmZXJlbmNlIGZvciB0 aGUgdGltZSBvZgo+IHRoZSBhY2Nlc3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxp bXJlLmRlYWtAaW50ZWwuY29tPgoKc3ViamVjdCBuZWVkcyB0byBiZSBmaXhlZCB0byBtZW50aW9u IHRoYXQgdGhpcyBpcyBmb3IgYWxsIHRoZSBzdHVmZiBpbgppOTE1X2RlYnVnZnMuYy4gV2l0aCB0 aGF0IGZpeGVkIGZvciBwYXRjaGVzIDQtODoKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZGVidWdmcy5jIHwgMjggKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IGVjMGMyYTA1ZS4uOWUxOWNmMCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gQEAgLTgyNSw4ICs4MjUsMTEgQEAgc3RhdGlj IGludCBpOTE1X2ludGVycnVwdF9pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqZGF0YSkK PiAgCQl9Cj4gIAo+ICAJCWZvcl9lYWNoX3BpcGUoZGV2X3ByaXYsIHBpcGUpIHsKPiAtCQkJaWYg KCFpbnRlbF9kaXNwbGF5X3Bvd2VyX2lzX2VuYWJsZWQoZGV2X3ByaXYsCj4gLQkJCQkJCVBPV0VS X0RPTUFJTl9QSVBFKHBpcGUpKSkgewo+ICsJCQllbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9t YWluIHBvd2VyX2RvbWFpbjsKPiArCj4gKwkJCXBvd2VyX2RvbWFpbiA9IFBPV0VSX0RPTUFJTl9Q SVBFKHBpcGUpOwo+ICsJCQlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJsZWQo ZGV2X3ByaXYsCj4gKwkJCQkJCQkJcG93ZXJfZG9tYWluKSkgewo+ICAJCQkJc2VxX3ByaW50Ziht LCAiUGlwZSAlYyBwb3dlciBkaXNhYmxlZFxuIiwKPiAgCQkJCQkgICBwaXBlX25hbWUocGlwZSkp Owo+ICAJCQkJY29udGludWU7Cj4gQEAgLTg0MCw2ICs4NDMsOCBAQCBzdGF0aWMgaW50IGk5MTVf aW50ZXJydXB0X2luZm8oc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICAJCQlzZXFf cHJpbnRmKG0sICJQaXBlICVjIElFUjpcdCUwOHhcbiIsCj4gIAkJCQkgICBwaXBlX25hbWUocGlw ZSksCj4gIAkJCQkgICBJOTE1X1JFQUQoR0VOOF9ERV9QSVBFX0lFUihwaXBlKSkpOwo+ICsKPiAr CQkJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoZGV2X3ByaXYsIHBvd2VyX2RvbWFpbik7Cj4gIAkJ fQo+ICAKPiAgCQlzZXFfcHJpbnRmKG0sICJEaXNwbGF5IEVuZ2luZSBwb3J0IGludGVycnVwdCBt YXNrOlx0JTA4eFxuIiwKPiBAQCAtNDAwNCw2ICs0MDA5LDcgQEAgc3RhdGljIGludCBwaXBlX2Ny Y19zZXRfc291cmNlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcGlwZSBwaXBlLAo+ICAJ c3RydWN0IGludGVsX3BpcGVfY3JjICpwaXBlX2NyYyA9ICZkZXZfcHJpdi0+cGlwZV9jcmNbcGlw ZV07Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRvX2ludGVsX2NydGMoaW50ZWxfZ2V0 X2NydGNfZm9yX3BpcGUoZGV2LAo+ICAJCQkJCQkJCQlwaXBlKSk7Cj4gKwllbnVtIGludGVsX2Rp c3BsYXlfcG93ZXJfZG9tYWluIHBvd2VyX2RvbWFpbjsKPiAgCXUzMiB2YWwgPSAwOyAvKiBzaHV0 IHVwIGdjYyAqLwo+ICAJaW50IHJldDsKPiAgCj4gQEAgLTQwMTQsNyArNDAyMCw4IEBAIHN0YXRp YyBpbnQgcGlwZV9jcmNfc2V0X3NvdXJjZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBlbnVtIHBp cGUgcGlwZSwKPiAgCWlmIChwaXBlX2NyYy0+c291cmNlICYmIHNvdXJjZSkKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCj4gLQlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfaXNfZW5hYmxlZChkZXZf cHJpdiwgUE9XRVJfRE9NQUlOX1BJUEUocGlwZSkpKSB7Cj4gKwlwb3dlcl9kb21haW4gPSBQT1dF Ul9ET01BSU5fUElQRShwaXBlKTsKPiArCWlmICghaW50ZWxfZGlzcGxheV9wb3dlcl9nZXRfaWZf ZW5hYmxlZChkZXZfcHJpdiwgcG93ZXJfZG9tYWluKSkgewo+ICAJCURSTV9ERUJVR19LTVMoIlRy eWluZyB0byBjYXB0dXJlIENSQyB3aGlsZSBwaXBlIGlzIG9mZlxuIik7Cj4gIAkJcmV0dXJuIC1F SU87Cj4gIAl9Cj4gQEAgLTQwMzEsNyArNDAzOCw3IEBAIHN0YXRpYyBpbnQgcGlwZV9jcmNfc2V0 X3NvdXJjZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBlbnVtIHBpcGUgcGlwZSwKPiAgCQlyZXQg PSBpdmJfcGlwZV9jcmNfY3RsX3JlZyhkZXYsIHBpcGUsICZzb3VyY2UsICZ2YWwpOwo+ICAKPiAg CWlmIChyZXQgIT0gMCkKPiAtCQlyZXR1cm4gcmV0Owo+ICsJCWdvdG8gb3V0Owo+ICAKPiAgCS8q IG5vbmUgLT4gcmVhbCBzb3VyY2UgdHJhbnNpdGlvbiAqLwo+ICAJaWYgKHNvdXJjZSkgewo+IEBA IC00MDQzLDggKzQwNTAsMTAgQEAgc3RhdGljIGludCBwaXBlX2NyY19zZXRfc291cmNlKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcGlwZSBwaXBlLAo+ICAJCWVudHJpZXMgPSBrY2FsbG9j KElOVEVMX1BJUEVfQ1JDX0VOVFJJRVNfTlIsCj4gIAkJCQkgIHNpemVvZihwaXBlX2NyYy0+ZW50 cmllc1swXSksCj4gIAkJCQkgIEdGUF9LRVJORUwpOwo+IC0JCWlmICghZW50cmllcykKPiAtCQkJ cmV0dXJuIC1FTk9NRU07Cj4gKwkJaWYgKCFlbnRyaWVzKSB7Cj4gKwkJCXJldCA9IC1FTk9NRU07 Cj4gKwkJCWdvdG8gb3V0Owo+ICsJCX0KPiAgCj4gIAkJLyoKPiAgCQkgKiBXaGVuIElQUyBnZXRz IGVuYWJsZWQsIHRoZSBwaXBlIENSQyBjaGFuZ2VzLiBTaW5jZSBJUFMgZ2V0cwo+IEBAIC00MTAw LDcgKzQxMDksMTIgQEAgc3RhdGljIGludCBwaXBlX2NyY19zZXRfc291cmNlKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIGVudW0gcGlwZSBwaXBlLAo+ICAJCWhzd19lbmFibGVfaXBzKGNydGMpOwo+ ICAJfQo+ICAKPiAtCXJldHVybiAwOwo+ICsJcmV0ID0gMDsKPiArCj4gK291dDoKPiArCWludGVs X2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBwb3dlcl9kb21haW4pOwo+ICsKPiArCXJldHVy biByZXQ7Cj4gIH0KPiAgCj4gIC8qCj4gLS0gCj4gMi41LjAKPiAKPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QK PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNv ZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK