From: Daniel Vetter Subject: Re: [PATCH 08/12] drm/i915: ensure the HW is powered when accessing the CRC HW block Date: Wed, 17 Feb 2016 17:09:18 +0100 Message-ID: <20160217160917.GK32705@phenom.ffwll.local> References: <1455296121-4742-1-git-send-email-imre.deak@intel.com> <1455296121-4742-9-git-send-email-imre.deak@intel.com> <20160216160253.GR32705@phenom.ffwll.local> <1455711649.2667.13.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 375076EA1B for ; Wed, 17 Feb 2016 16:08:52 +0000 (UTC) Received: by mail-wm0-f47.google.com with SMTP id g62so244007875wme.0 for ; Wed, 17 Feb 2016 08:08:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <1455711649.2667.13.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBGZWIgMTcsIDIwMTYgYXQgMDI6MjA6NDlQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE9uIHRpLCAyMDE2LTAyLTE2IGF0IDE3OjAyICswMTAwLCBEYW5pZWwgVmV0dGVyIHdyb3Rl Ogo+ID4gT24gRnJpLCBGZWIgMTIsIDIwMTYgYXQgMDY6NTU6MTdQTSArMDIwMCwgSW1yZSBEZWFr IHdyb3RlOgo+ID4gPiBUaGUgYXNzdW1wdGlvbiB3aGVuIGFkZGluZyB0aGUgaW50ZWxfZGlzcGxh eV9wb3dlcl9pc19lbmFibGVkKCkKPiA+ID4gY2hlY2tzCj4gPiA+IHdhcyB0aGF0IGlmIGl0IHJl dHVybnMgc3VjY2VzcyB0aGUgcG93ZXIgY2FuJ3QgYmUgdHVybmVkIG9mZgo+ID4gPiBhZnRlcndh cmRzCj4gPiA+IGR1cmluZyB0aGUgSFcgYWNjZXNzLCB3aGljaCBpcyBndWFyYW50ZWVkIGJ5IG1v ZGVzZXQgbG9ja3MuIFRoaXMKPiA+ID4gaXNuJ3QKPiA+ID4gYWx3YXlzIHRydWUsIHNvIG1ha2Ug c3VyZSB3ZSBob2xkIGEgZGVkaWNhdGVkIHJlZmVyZW5jZSBmb3IgdGhlCj4gPiA+IHRpbWUgb2YK PiA+ID4gdGhlIGFjY2Vzcy4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8 aW1yZS5kZWFrQGludGVsLmNvbT4KPiA+IAo+ID4gc3ViamVjdCBuZWVkcyB0byBiZSBmaXhlZCB0 byBtZW50aW9uIHRoYXQgdGhpcyBpcyBmb3IgYWxsIHRoZSBzdHVmZgo+ID4gaW4KPiA+IGk5MTVf ZGVidWdmcy5jLgo+IAo+IEFoLCB5ZWHCoGk5MTVfaW50ZXJydXB0X2luZm8oKSBpcyBhbHNvIGNo YW5nZWQsIHdpbGwgdXBkYXRlZCB0aGF0IGluIHRoZQo+IGxvZy4KCkFoIHJpZ2h0IG1ha2VzIHNl bnNlLiBJIHRob3VnaHQgSSBjb3VudGVkIG1vcmUgdG8gY29udmVydCBpbgppbnRlbF9kaXNwbGF5 LmMgdGhhbiB3aGF0IHdhcyBpbiB5b3VyIHBhdGNoZXMsIHBsdXMgdGhlIGVycm9yIGNhcHR1cmUK c3R1ZmYuIEFuZCBub3QgY29udmVydGluZyBlcnJvciBjYXB0dXJlIGlzIGluZGVlZCB3aGF0IHdl IG5lZWQgdG8gZG8gLi4uCi1EYW5pZWwKCj4gCj4gPiBXaXRoIHRoYXQgZml4ZWQgZm9yIHBhdGNo ZXMgNC04Ogo+ID4gCj4gPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBmZndsbC5jaD4KPiA+IAo+ID4gCj4gPiA+IC0tLQo+ID4gPiDCoGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZGVidWdmcy5jIHwgMjggKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ID4gLS0t LS0KPiA+ID4gwqAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMo LSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYwo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gPiA+ IGluZGV4IGVjMGMyYTA1ZS4uOWUxOWNmMCAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kZWJ1Z2ZzLmMKPiA+ID4gQEAgLTgyNSw4ICs4MjUsMTEgQEAgc3RhdGljIGludCBpOTE1 X2ludGVycnVwdF9pbmZvKHN0cnVjdCBzZXFfZmlsZQo+ID4gPiAqbSwgdm9pZCAqZGF0YSkKPiA+ ID4gwqAJCX0KPiA+ID4gwqAKPiA+ID4gwqAJCWZvcl9lYWNoX3BpcGUoZGV2X3ByaXYsIHBpcGUp IHsKPiA+ID4gLQkJCWlmCj4gPiA+ICghaW50ZWxfZGlzcGxheV9wb3dlcl9pc19lbmFibGVkKGRl dl9wcml2LAo+ID4gPiAtCQkJCQkJUE9XRVJfRE9NQUlOX1BJUEUoCj4gPiA+IHBpcGUpKSkgewo+ ID4gPiArCQkJZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbgo+ID4gPiBwb3dlcl9kb21h aW47Cj4gPiA+ICsKPiA+ID4gKwkJCXBvd2VyX2RvbWFpbiA9IFBPV0VSX0RPTUFJTl9QSVBFKHBp cGUpOwo+ID4gPiArCQkJaWYKPiA+ID4gKCFpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldF9pZl9lbmFi bGVkKGRldl9wcml2LAo+ID4gPiArCQkJCQkJCQlwbwo+ID4gPiB3ZXJfZG9tYWluKSkgewo+ID4g PiDCoAkJCQlzZXFfcHJpbnRmKG0sICJQaXBlICVjIHBvd2VyCj4gPiA+IGRpc2FibGVkXG4iLAo+ ID4gPiDCoAkJCQkJwqDCoMKgcGlwZV9uYW1lKHBpcGUpKTsKPiA+ID4gwqAJCQkJY29udGludWU7 Cj4gPiA+IEBAIC04NDAsNiArODQzLDggQEAgc3RhdGljIGludCBpOTE1X2ludGVycnVwdF9pbmZv KHN0cnVjdCBzZXFfZmlsZQo+ID4gPiAqbSwgdm9pZCAqZGF0YSkKPiA+ID4gwqAJCQlzZXFfcHJp bnRmKG0sICJQaXBlICVjIElFUjpcdCUwOHhcbiIsCj4gPiA+IMKgCQkJCcKgwqDCoHBpcGVfbmFt ZShwaXBlKSwKPiA+ID4gwqAJCQkJwqDCoMKgSTkxNV9SRUFEKEdFTjhfREVfUElQRV9JRVIocGlw ZQo+ID4gPiApKSk7Cj4gPiA+ICsKPiA+ID4gKwkJCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRl dl9wcml2LAo+ID4gPiBwb3dlcl9kb21haW4pOwo+ID4gPiDCoAkJfQo+ID4gPiDCoAo+ID4gPiDC oAkJc2VxX3ByaW50ZihtLCAiRGlzcGxheSBFbmdpbmUgcG9ydCBpbnRlcnJ1cHQKPiA+ID4gbWFz azpcdCUwOHhcbiIsCj4gPiA+IEBAIC00MDA0LDYgKzQwMDksNyBAQCBzdGF0aWMgaW50IHBpcGVf Y3JjX3NldF9zb3VyY2Uoc3RydWN0Cj4gPiA+IGRybV9kZXZpY2UgKmRldiwgZW51bSBwaXBlIHBp cGUsCj4gPiA+IMKgCXN0cnVjdCBpbnRlbF9waXBlX2NyYyAqcGlwZV9jcmMgPSAmZGV2X3ByaXYt Cj4gPiA+ID5waXBlX2NyY1twaXBlXTsKPiA+ID4gwqAJc3RydWN0IGludGVsX2NydGMgKmNydGMg PQo+ID4gPiB0b19pbnRlbF9jcnRjKGludGVsX2dldF9jcnRjX2Zvcl9waXBlKGRldiwKPiA+ID4g wqAJCQkJCQkJCQkKPiA+ID4gcGlwZSkpOwo+ID4gPiArCWVudW0gaW50ZWxfZGlzcGxheV9wb3dl cl9kb21haW4gcG93ZXJfZG9tYWluOwo+ID4gPiDCoAl1MzIgdmFsID0gMDsgLyogc2h1dCB1cCBn Y2MgKi8KPiA+ID4gwqAJaW50IHJldDsKPiA+ID4gwqAKPiA+ID4gQEAgLTQwMTQsNyArNDAyMCw4 IEBAIHN0YXRpYyBpbnQgcGlwZV9jcmNfc2V0X3NvdXJjZShzdHJ1Y3QKPiA+ID4gZHJtX2Rldmlj ZSAqZGV2LCBlbnVtIHBpcGUgcGlwZSwKPiA+ID4gwqAJaWYgKHBpcGVfY3JjLT5zb3VyY2UgJiYg c291cmNlKQo+ID4gPiDCoAkJcmV0dXJuIC1FSU5WQUw7Cj4gPiA+IMKgCj4gPiA+IC0JaWYgKCFp bnRlbF9kaXNwbGF5X3Bvd2VyX2lzX2VuYWJsZWQoZGV2X3ByaXYsCj4gPiA+IFBPV0VSX0RPTUFJ Tl9QSVBFKHBpcGUpKSkgewo+ID4gPiArCXBvd2VyX2RvbWFpbiA9IFBPV0VSX0RPTUFJTl9QSVBF KHBpcGUpOwo+ID4gPiArCWlmICghaW50ZWxfZGlzcGxheV9wb3dlcl9nZXRfaWZfZW5hYmxlZChk ZXZfcHJpdiwKPiA+ID4gcG93ZXJfZG9tYWluKSkgewo+ID4gPiDCoAkJRFJNX0RFQlVHX0tNUygi VHJ5aW5nIHRvIGNhcHR1cmUgQ1JDIHdoaWxlIHBpcGUgaXMKPiA+ID4gb2ZmXG4iKTsKPiA+ID4g wqAJCXJldHVybiAtRUlPOwo+ID4gPiDCoAl9Cj4gPiA+IEBAIC00MDMxLDcgKzQwMzgsNyBAQCBz dGF0aWMgaW50IHBpcGVfY3JjX3NldF9zb3VyY2Uoc3RydWN0Cj4gPiA+IGRybV9kZXZpY2UgKmRl diwgZW51bSBwaXBlIHBpcGUsCj4gPiA+IMKgCQlyZXQgPSBpdmJfcGlwZV9jcmNfY3RsX3JlZyhk ZXYsIHBpcGUsICZzb3VyY2UsCj4gPiA+ICZ2YWwpOwo+ID4gPiDCoAo+ID4gPiDCoAlpZiAocmV0 ICE9IDApCj4gPiA+IC0JCXJldHVybiByZXQ7Cj4gPiA+ICsJCWdvdG8gb3V0Owo+ID4gPiDCoAo+ ID4gPiDCoAkvKiBub25lIC0+IHJlYWwgc291cmNlIHRyYW5zaXRpb24gKi8KPiA+ID4gwqAJaWYg KHNvdXJjZSkgewo+ID4gPiBAQCAtNDA0Myw4ICs0MDUwLDEwIEBAIHN0YXRpYyBpbnQgcGlwZV9j cmNfc2V0X3NvdXJjZShzdHJ1Y3QKPiA+ID4gZHJtX2RldmljZSAqZGV2LCBlbnVtIHBpcGUgcGlw ZSwKPiA+ID4gwqAJCWVudHJpZXMgPSBrY2FsbG9jKElOVEVMX1BJUEVfQ1JDX0VOVFJJRVNfTlIs Cj4gPiA+IMKgCQkJCcKgwqBzaXplb2YocGlwZV9jcmMtPmVudHJpZXNbMF0pLAo+ID4gPiDCoAkJ CQnCoMKgR0ZQX0tFUk5FTCk7Cj4gPiA+IC0JCWlmICghZW50cmllcykKPiA+ID4gLQkJCXJldHVy biAtRU5PTUVNOwo+ID4gPiArCQlpZiAoIWVudHJpZXMpIHsKPiA+ID4gKwkJCXJldCA9IC1FTk9N RU07Cj4gPiA+ICsJCQlnb3RvIG91dDsKPiA+ID4gKwkJfQo+ID4gPiDCoAo+ID4gPiDCoAkJLyoK PiA+ID4gwqAJCcKgKiBXaGVuIElQUyBnZXRzIGVuYWJsZWQsIHRoZSBwaXBlIENSQyBjaGFuZ2Vz Lgo+ID4gPiBTaW5jZSBJUFMgZ2V0cwo+ID4gPiBAQCAtNDEwMCw3ICs0MTA5LDEyIEBAIHN0YXRp YyBpbnQgcGlwZV9jcmNfc2V0X3NvdXJjZShzdHJ1Y3QKPiA+ID4gZHJtX2RldmljZSAqZGV2LCBl bnVtIHBpcGUgcGlwZSwKPiA+ID4gwqAJCWhzd19lbmFibGVfaXBzKGNydGMpOwo+ID4gPiDCoAl9 Cj4gPiA+IMKgCj4gPiA+IC0JcmV0dXJuIDA7Cj4gPiA+ICsJcmV0ID0gMDsKPiA+ID4gKwo+ID4g PiArb3V0Ogo+ID4gPiArCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBwb3dlcl9k b21haW4pOwo+ID4gPiArCj4gPiA+ICsJcmV0dXJuIHJldDsKPiA+ID4gwqB9Cj4gPiA+IMKgCj4g PiA+IMKgLyoKPiA+ID4gLS0gCj4gPiA+IDIuNS4wCj4gPiA+IAo+ID4gPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiA+IAoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=