From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/atomic: Refuse to steal encoders from connectors not part of the state. Date: Thu, 18 Feb 2016 12:07:08 +0100 Message-ID: <20160218110708.GU32705@phenom.ffwll.local> References: <1455785683-5477-1-git-send-email-maarten.lankhorst@linux.intel.com> <1455785683-5477-4-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC2E06EB31 for ; Thu, 18 Feb 2016 11:06:41 +0000 (UTC) Received: by mail-wm0-x234.google.com with SMTP id g62so19894080wme.0 for ; Thu, 18 Feb 2016 03:06:41 -0800 (PST) Content-Disposition: inline In-Reply-To: <1455785683-5477-4-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMTgsIDIwMTYgYXQgMDk6NTQ6NDNBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQmVjYXVzZSBlbmNvZGVyIDwtPiBjb25uZWN0b3IgbWFwcGluZyBpcyBmaXhl ZCB3aGVuIG5vdCBtb3ZpbmcgdG8KPiBhbm90aGVyIGNydGMgd2UgY2FuIGp1c3QgcmVqZWN0IGNv bm5lY3RvcnMgdHJ5aW5nIHRvIHN0ZWFsIGFuIGVuY29kZXIKPiBmcm9tIGEgY29ubmVjdG9yIG5v dCBwYXJ0IG9mIHRoZSBzdGF0ZS4gVGhpcyB3b24ndCBicmVhayBNU1Qgb24gaTkxNQo+IGJlY2F1 c2UgaW4gdGhhdCBjYXNlIGNvbm5lY3RvcnMgd2lsbCBiZSBwYXJ0IG9mIHRoZSBzdGF0ZSBpZiB5 b3Ugc3dpdGNoCj4gdGhlbSBiZXR3ZWVuIGNydGMncy4gSWYgdGhleSdyZSBub3QgdGhleSBzdGF5 IG9uIHRoZSBzYW1lIGNydGMsIGFuZAo+IGVuY29kZXIgc3RlYWxpbmcgd291bGQgaGF2ZSBmYWls ZWQgYW55d2F5LgoKV2UgbXVzdCBkbyB0aGlzIGZvciBiYWNrd2FyZHMgY29tcGF0LiBzZXRDcnRj IG9uIGEgY29ubmVjdG9yIHRoYXQgbmVlZHMgYW4KZW5jb2RlciBhbHJlYWR5IHVzZWQgb24gc29t ZSBvdGhlciBjcnRjIGlzIHN1cHBvc2VkIHRvIGRpc2FibGUgdGhhdAplbmNvZGVyIChhbmQgdGhl IGVudGlyZSBwaXBlIGlmIGl0J3MgYWxsIHVudXNlZCkgaWYgd2UgbmVlZCBpdC4KLURhbmllbAoK PiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxw ZXIuYyB8IDQzICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggZmE3MDg1NTk1NDJjLi5iMjAyOGQ1OTI0ODMg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC05MiwxNCArOTIsMjEg QEAgY2hlY2tfcGVuZGluZ19lbmNvZGVyX2Fzc2lnbm1lbnQoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlLAo+ICAJCQkJIGludCBjb25uX2lkeCkKPiAgewo+ICAJc3RydWN0IGRybV9jb25u ZWN0b3IgKmNvbm5lY3RvcjsKPiAtCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0 YXRlOwo+IC0JaW50IGk7Cj4gIAo+IC0JZm9yX2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRl LCBjb25uZWN0b3IsIGNvbm5fc3RhdGUsIGkpIHsKPiAtCQlpZiAoaSA+PSBjb25uX2lkeCkKPiAt CQkJYnJlYWs7Cj4gKwlkcm1fZm9yX2VhY2hfY29ubmVjdG9yKGNvbm5lY3Rvciwgc3RhdGUtPmRl dikgewo+ICsJCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlID0KPiArCQkJ ZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY29ubmVjdG9yX3N0YXRlKHN0YXRlLAo+ICsJCQkJCQkJ CWNvbm5lY3Rvcik7Cj4gIAo+IC0JCWlmIChjb25uX3N0YXRlLT5iZXN0X2VuY29kZXIgPT0gbmV3 X2VuY29kZXIpCj4gKwkJaWYgKCFjb25uX3N0YXRlKSB7Cj4gKwkJCWlmIChjb25uZWN0b3ItPnN0 YXRlLT5iZXN0X2VuY29kZXIgPT0gbmV3X2VuY29kZXIpCj4gKwkJCQlyZXR1cm4gZmFsc2U7Cj4g Kwo+ICsJCQljb250aW51ZTsKPiArCQl9Cj4gKwo+ICsJCWlmIChkcm1fY29ubmVjdG9yX2luZGV4 KGNvbm5lY3RvcikgPCBjb25uX2lkeCAmJgo+ICsJCSAgICBjb25uX3N0YXRlLT5iZXN0X2VuY29k ZXIgPT0gbmV3X2VuY29kZXIpCj4gIAkJCXJldHVybiBmYWxzZTsKPiAgCX0KPiAgCj4gQEAgLTE0 OSwyOSArMTU2LDE5IEBAIHNldF9iZXN0X2VuY29kZXIoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlLAo+ICAKPiAgc3RhdGljIGludAo+ICBzdGVhbF9lbmNvZGVyKHN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZSwKPiAtCSAgICAgIHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikK PiArCSAgICAgIHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPiArCSAgICAgIGludCBjb25u X2lkeCkKPiAgewo+IC0Jc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJnN0YXRlLT5k ZXYtPm1vZGVfY29uZmlnOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiAgCXN0cnVjdCBkcm1fY29ubmVj dG9yX3N0YXRlICpjb25uZWN0b3Jfc3RhdGU7Cj4gKwlpbnQgaTsKPiAgCj4gLQkvKgo+IC0JICog V2UgY2FuIG9ubHkgc3RlYWwgYW4gZW5jb2RlciBjb21pbmcgZnJvbSBhIGNvbm5lY3Rvciwgd2hp Y2ggbWVhbnMgd2UKPiAtCSAqIG11c3QgYWxyZWFkeSBob2xkIHRoZSBjb25uZWN0aW9uX211dGV4 Lgo+IC0JICovCj4gLQlXQVJOX09OKCFkcm1fbW9kZXNldF9pc19sb2NrZWQoJmNvbmZpZy0+Y29u bmVjdGlvbl9tdXRleCkpOwo+IC0KPiAtCWxpc3RfZm9yX2VhY2hfZW50cnkoY29ubmVjdG9yLCAm Y29uZmlnLT5jb25uZWN0b3JfbGlzdCwgaGVhZCkgewo+ICsJZm9yX2VhY2hfY29ubmVjdG9yX2lu X3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsIGNvbm5lY3Rvcl9zdGF0ZSwgaSkgewo+ICAJCXN0cnVj dCBkcm1fY3J0YyAqZW5jb2Rlcl9jcnRjOwo+ICAKPiAtCQlpZiAoY29ubmVjdG9yLT5zdGF0ZS0+ YmVzdF9lbmNvZGVyICE9IGVuY29kZXIpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAtCQljb25uZWN0 b3Jfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jb25uZWN0b3Jfc3RhdGUoc3RhdGUsCj4gLQkJCQkJ CQkJIGNvbm5lY3Rvcik7Cj4gLQkJaWYgKElTX0VSUihjb25uZWN0b3Jfc3RhdGUpKQo+IC0JCQly ZXR1cm4gUFRSX0VSUihjb25uZWN0b3Jfc3RhdGUpOwo+ICsJCWlmIChpID49IGNvbm5faWR4KQo+ ICsJCQlicmVhazsKPiAgCj4gIAkJaWYgKGNvbm5lY3Rvcl9zdGF0ZS0+YmVzdF9lbmNvZGVyICE9 IGVuY29kZXIgfHwKPiAgCQkgICAgV0FSTl9PTighY29ubmVjdG9yX3N0YXRlLT5jcnRjKSkKPiBA QCAtMjc5LDcgKzI3Niw3IEBAIHVwZGF0ZV9jb25uZWN0b3Jfcm91dGluZyhzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUsCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gIAo+IC0JcmV0 ID0gc3RlYWxfZW5jb2RlcihzdGF0ZSwgbmV3X2VuY29kZXIpOwo+ICsJcmV0ID0gc3RlYWxfZW5j b2RlcihzdGF0ZSwgbmV3X2VuY29kZXIsIGNvbm5faWR4KTsKPiAgCWlmIChyZXQpIHsKPiAgCQlE Uk1fREVCVUdfQVRPTUlDKCJFbmNvZGVyIHN0ZWFsaW5nIGZhaWxlZCBmb3IgW0NPTk5FQ1RPUjol ZDolc11cbiIsCj4gIAkJCQkgY29ubmVjdG9yLT5iYXNlLmlkLAo+IC0tIAo+IDIuMS4wCj4gCj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==