From: Mikko Rapeli Subject: Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h Date: Fri, 26 Feb 2016 09:18:17 +0200 Message-ID: <20160226071817.GG6104@lakka.kapsi.fi> References: <20160106092007.1c5a0c75@xeon-e3> <20160225210856.GB10608@pox.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Hemminger , Pablo Neira Ayuso , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: Thomas Graf Return-path: Content-Disposition: inline In-Reply-To: <20160225210856.GB10608@pox.localdomain> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Thu, Feb 25, 2016 at 10:08:56PM +0100, Thomas Graf wrote: > On 01/06/16 at 09:20am, Stephen Hemminger wrote: > > This commit breaks compilation of iproute2 with net-next. > > > > commit 1ffad83dffd675cd742286ae82dca7d746cb0da8 > > Author: Mikko Rapeli > > Date: Thu Oct 15 07:56:30 2015 +0200 > > > > netfilter: fix include files for compilation > > > > Add missing header dependencies and other small changes so that each file > > compiles alone in userspace. > > > > Signed-off-by: Mikko Rapeli > > Signed-off-by: Pablo Neira Ayuso > > > > For iproute2, a copy of kernel headers (from make install_headers) is used. > > After this change. the build of x_tables.c fails because IFNAMSIZ is already > > defined in net/if.h > > There is another issue with this commit. iptables.h included from m_ipt.c > includes xtables.h which includes which is not > available on a system without xtables. > > gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DHAVE_SETNS -DHAVE_ELF -DCONFIG_GACT -DCONFIG_GACT_PROB -DIPT_LIB_DIR=\"/lib/xtables\" -DYY_NO_INPUT -c -o m_ipt.o m_ipt.c > In file included from ../include/iptables.h:5:0, > from m_ipt.c:17: > ../include/xtables.h:34:29: fatal error: xtables-version.h: No such file or directory > #include I don't see any dependencies from kernel side uapi headers to iptables or xtables in my tree based on v4.5-rc2. Maybe this is a problem in iproute2. -Mikko