Date: Tue, 1 Mar 2016 15:21:35 +0100
From: Andrei Gherzan <andrei@gherzan.ro>
To: Jonathan Liu <net147@gmail.com>
Message-ID: <20160301142135.GE21641@resin.home>
References: <1456840719-14318-1-git-send-email-net147@gmail.com>
MIME-Version: 1.0
In-Reply-To: <1456840719-14318-1-git-send-email-net147@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH v3 1/3] rpi-mkimage: install to bindir instead of libexecdir
Precedence: list
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 02, 2016 at 12:58:37AM +1100, Jonathan Liu wrote:
> On fido and earlier branches, ${libexecdir} depends on ${BPN} so it
> is not a good choice as ${libexecdir} is different depending on the
> recipe name.
>
> For example, rpi-mkimage would install mkknlimg to:
>   [...]/sysroots/x86_64-linux/usr/lib/rpi-mkimage
> but linux-raspberrypi would look for mkknlimg in the path:
>   [...]/sysroots/x86_64-linux/usr/lib/linux-raspberrypi
>
> To resolve this, we use ${bindir} instead as it doesn't depend on
> ${BPN} in fido and earlier branches as well as in the master branch.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  recipes-bsp/rpi-mkimage/rpi-mkimage_git.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-bsp/rpi-mkimage/rpi-mkimage_git.bb b/recipes-bsp/rpi-mkimage/rpi-mkimage_git.bb
> index 7dea43d..cce91d7 100644
> --- a/recipes-bsp/rpi-mkimage/rpi-mkimage_git.bb
> +++ b/recipes-bsp/rpi-mkimage/rpi-mkimage_git.bb
> @@ -15,8 +15,8 @@ SRC_URI = " \
>  S = "${WORKDIR}/git"
>
>  do_install () {
> -    install -d ${D}${libexecdir}
> -    install -t ${D}${libexecdir} mkimage/*
> +    install -d ${D}${bindir}
> +    install -t ${D}${bindir} mkimage/*
>  }
>
>  BBCLASSEXTEND = "native"

Tested on default build and merged to master (all 3 patches). Thanks.

--
Andrei Gherzan