Received-SPF: pass (google.com: domain of bounce-md_30481620.56d73595.v1-a76a24574c1947938fb478d4d4e42703@mandrillapp.com designates 205.201.137.77 as permitted sender) client-ip=205.201.137.77;
DomainKey-Signature: a=rsa-sha1; c=nofws; q=dns; s=mandrill; d=linuxfoundation.org;
 b=ZQXH3cto1tcfae+eibuvBRlYdCnEWlIt9m7OD1CCjf4eueeHelQpS5Usmv/2NVT4kRjtzZD9h4Eb
   iq9zPdUtLh2YxeAewNjxzF/ZJmqygU4w2tNGPZVQ5S6WvGdFqvUwoiBq1VKnSge6zogXveoPZmsV
   +4dLfrY2AAXgKsTUYEQ=;
From: Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] [PATCH v2] staging: lustre: mgc: Bool tests do not need comparison
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: <outreachy-kernel@googlegroups.com>
Message-Id: <20160302032952.GA14645@kroah.com>
References: <20160227184909.GA2991@Karyakshetra>
In-Reply-To: <20160227184909.GA2991@Karyakshetra>
Date: Wed, 02 Mar 2016 18:48:53 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On Sun, Feb 28, 2016 at 12:19:09AM +0530, Bhaktipriya Shridhar wrote:
> Bool initializations should use true and false thus bool tests don't
> need an explicit comparison.
> 
> This issue was found using the following Coccinelle script:
> @@
> bool x;
> symbol true;
> symbol false;
> @@
> 
> (
> - x == true
> + x
> |
> - true == x
> + x
> |
> - x != true
> + !x
> |
> - true != x
> + !x
> |
> - x == false
> + !x
> |
> - false == x
> + !x
> |
> - x != false
> + x
> |
> - false != x
> + x
> )
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  Changes in v2:
> 	-Fixed typo "lusture" to "lustre" in the subject
> 
>  drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> index 6fc8225..aea5fc3 100644
> --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
> +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> @@ -1394,7 +1394,7 @@ again:
>  	eof = res->mcr_offset == res->mcr_size;
> 
>  	CDEBUG(D_INFO, "Latest version %lld, more %d.\n",
> -	       res->mcr_offset, eof == false);
> +	       res->mcr_offset, !eof);

eek, that's horrid to try to read, can you understand that now?

Please don't do that.

greg k-h