Received-SPF: pass (google.com: domain of bounce-md_30481620.56d73582.v1-a13c58472601400d98a172c14799c1fa@mandrillapp.com designates 205.201.137.77 as permitted sender) client-ip=205.201.137.77;
DomainKey-Signature: a=rsa-sha1; c=nofws; q=dns; s=mandrill; d=linuxfoundation.org;
 b=a7jV5H++ToQKzmk1siR+sPYHXAvM8hdG6uxcz4Sna3Ui8QhC33n8kpvFTdBLYo/+uWl3KjvWvOlO
   IMjAlaupp78of0S/AGDKTSjaBEFolQSHtDl5jVWVAGBBllokD7bFvFpoB2kIimhCyozPpn3HCkVG
   rCMw8SdRGi4QHzB0ojY=;
From: Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] [PATCH v4 5/5] staging: lustre: ptlrpc: Remove useless return variables
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: <outreachy-kernel@googlegroups.com>
Message-Id: <20160302033118.GA14776@kroah.com>
References: <20160226094328.GA10635@Karyakshetra>
In-Reply-To: <20160226094328.GA10635@Karyakshetra>
Date: Wed, 02 Mar 2016 18:48:34 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On Fri, Feb 26, 2016 at 03:13:28PM +0530, Bhaktipriya Shridhar wrote:
> This patch removes unnecessary return variables and compresses the
> return logic.
> The coccinelle script that finds and fixes this issue is:
> @@ type T; identifier i,f; constant C; @@
> - T i;
> ...when != i
> when strict
> ( return -C;
> |
> - i =
> + return
> f(...);
> - return i;
> )
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  Changes in v4:
> 	-Corrected typo lusture in the subject. Made it to lustre
> 
>  drivers/staging/lustre/lustre/ptlrpc/client.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c
> index 9b89068..031502e 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/client.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
> @@ -421,10 +421,7 @@ void ptlrpc_request_cache_fini(void)
> 
>  struct ptlrpc_request *ptlrpc_request_cache_alloc(gfp_t flags)
>  {
> -	struct ptlrpc_request *req;
> -
> -	req = kmem_cache_alloc(request_cache, flags | __GFP_ZERO);
> -	return req;
> +	return kmem_cache_alloc(request_cache, flags | __GFP_ZERO);
>  }
> 
>  void ptlrpc_request_cache_free(struct ptlrpc_request *req)

This patch didn't apply :(