Received: from eggs.gnu.org ([2001:4830:134:3::10]:58769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abA1E-0001bC-L0 for qemu-devel@nongnu.org; Wed, 02 Mar 2016 11:53:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abA1D-0007tx-Rd for qemu-devel@nongnu.org; Wed, 02 Mar 2016 11:53:00 -0500 Date: Wed, 2 Mar 2016 17:52:52 +0100 From: Kevin Wolf Message-ID: <20160302165252.GG4494@noname.redhat.com> References: <1456518142-9849-1-git-send-email-kwolf@redhat.com> <1456518142-9849-3-git-send-email-kwolf@redhat.com> <56D71915.1020802@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NMuMz9nt05w80d4+" Content-Disposition: inline In-Reply-To: <56D71915.1020802@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org --NMuMz9nt05w80d4+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 02.03.2016 um 17:47 hat Max Reitz geschrieben: > On 26.02.2016 21:22, Kevin Wolf wrote: > > The new functions handles the data that is taken from the > > BlockDriverState. > >=20 > > Signed-off-by: Kevin Wolf > > --- > > block/qapi.c | 31 ++++++++++++++++++++----------- > > 1 file changed, 20 insertions(+), 11 deletions(-) >=20 > Reviewed-by: Max Reitz >=20 > Now that I see s->stats->wr_highest_offset in this function, thus > piquing my interest in s->stats... How about another patch which makes > bdrv_query_blk_stats() take the BlockDeviceStats pointer instead of > BlockStats? Hm, doesn't work any more after patch 3. Which doesn't necessarily mean that it's a bad thought, maybe s->device can be set in the caller instead. Kevin --NMuMz9nt05w80d4+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJW1xpkAAoJEH8JsnLIjy/W5sQP/joTd6b9QkWAFqm+8YJFmu7H hPGguIAQcqWbsX86SSTALk3KDR7kUsRArWTTQ7nX7yO7aLoUiHBRufyJ70fmWlaW Lmx08BFYiFtltau9qAF4SjNN2vlX/6V6phIbXTMx9/gC4mYCMC9czAHpBJJxDHa8 fCAUlxgdHQ2P3z5fGbqWyJo7wr+i6VYypBtYa33DSXE9AXT9+uqxbRGYmM8sSXeR NjhLatyCr/x38Z5It6N/78wwGGxhFFrbA+crKQxaO+aMY4z4dfl7kmDhB7DqhGdN EjXt/i1CEYWcYRXNDBPb1EhvP1Zo8k5v1qI4+yfYK+38R5EzDXErYzICL/tKaeCD OI3lshcqbn55eCzwei4FO5UrYcnBmIxu/N61ztCaemQTAF4aTDj1pqP7JzR8wBaq WuhUpAnGxiiGN8HvPkP/fwKgcaw38pl+NFd/0YzcRHNT4kTx9jmUQ5meCPCeleNl zmjFlcQwmgOE1/kxENQ3WNXnUM9HBKE/rgxC3zLMXz+OuAwtiTnhaf6kqZCdVDk4 XS5TOWcK7cAQRoR3MV+aJWOvVg2wl8LNjaPc/5ldWtPE4YOp+qlHbvb2YfDh0Pkm 5sFqoi0u+uZxDV4rg/Z/kyy4xh2hpTfa1cILJX8r41kCSFYiZ7DMs1e5n0wBa8YM uC+z49hBrAJvQ9Vw6tUR =GZ8c -----END PGP SIGNATURE----- --NMuMz9nt05w80d4+--