Received-SPF: pass (google.com: domain of nevola@gmail.com designates 2a00:1450:400c:c09::231 as permitted sender) client-ip=2a00:1450:400c:c09::231;
Date: Sun, 6 Mar 2016 21:11:03 +0100
From: Laura Garcia <nevola@gmail.com>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH] extensions: libipt_icmp: Add translation to nft
Message-ID: <20160306201101.GA9308@sonyv>
References: <20160305200039.GA14269@sonyv>
 <CAKHNQQE7S-x63bez0qdhwujESbwqPHSftc_aMXHkHh=Y5amrZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKHNQQE7S-x63bez0qdhwujESbwqPHSftc_aMXHkHh=Y5amrZA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Sun, Mar 06, 2016 at 03:31:15PM +0530, Shivani Bhardwaj wrote:
> There are some icmp types that nftables does not support, have you

And these types (and subtypes) are not supported yet or will never be supported?

> tried adding up rules corresponding to all the packet types?
> 

Yes, but not all of them.

> $ sudo nft add table filter
> $ sudo nft add chain filter INPUT { type filter hook input priority 0\;}
> $ sudo <your generated rule goes here>
> 
> Please consider finding out such packet types and mention about them
> in commit message.

Ok.

> Also, here you are using the array icmp_codes, this will give out the
> same packet names as iptables. But, some packet names are different in
> nftables. May be not in case of icmp but in case of icmp6. Please have
> a look at this.
> 

Ok, as there isn't a direct translation I'll provide a v2 with a list
of supported types.

Thanks!