X-GM-THRID: 6258660898055913472 X-Received: by 10.28.189.130 with SMTP id n124mr1569836wmf.4.1457369937417; Mon, 07 Mar 2016 08:58:57 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.25.156.132 with SMTP id f126ls135339lfe.71.gmail; Mon, 07 Mar 2016 08:58:56 -0800 (PST) X-Received: by 10.112.40.200 with SMTP id z8mr1510435lbk.16.1457369936698; Mon, 07 Mar 2016 08:58:56 -0800 (PST) Return-Path: Received: from mail.us.es (mail.us.es. [193.147.175.20]) by gmr-mx.google.com with ESMTPS id 185si439888wml.0.2016.03.07.08.58.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Mar 2016 08:58:56 -0800 (PST) Received-SPF: pass (google.com: domain of pneira@us.es designates 193.147.175.20 as permitted sender) client-ip=193.147.175.20; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of pneira@us.es designates 193.147.175.20 as permitted sender) smtp.mailfrom=pneira@us.es Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 2FA514B0FF for ; Mon, 7 Mar 2016 17:58:56 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2245EDA8F8 for ; Mon, 7 Mar 2016 17:58:56 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 17945DA380; Mon, 7 Mar 2016 17:58:56 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-103.2 required=7.5 tests=BAYES_50, HEADER_FROM_DIFFERENT_DOMAINS,SMTPAUTH_US,SPF_HELO_FAIL,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1A737DA380 for ; Mon, 7 Mar 2016 17:58:54 +0100 (CET) Received: from 192.168.1.13 (192.168.1.13) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/522/antivirus1-rhel7.int); Mon, 07 Mar 2016 17:58:54 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/522/antivirus1-rhel7.int) Received: (qmail 31694 invoked from network); 7 Mar 2016 17:58:53 +0100 Received: from 129.166.216.87.static.jazztel.es (HELO us.es) (1984lsi@87.216.166.129) by mail.us.es with AES128-SHA encrypted SMTP; 7 Mar 2016 17:58:53 +0100 Date: Mon, 7 Mar 2016 17:58:53 +0100 From: Pablo Neira Ayuso To: Laura Garcia Liebana Cc: netfilter-devel@vger.kernel.org, shivanib134@gmail.com, outreachy-kernel@googlegroups.com Subject: Re: [PATCHv2] extensions: libipt_icmp: Add translation to nft Message-ID: <20160307165853.GA29439@salvia> References: <20160306222442.GA20945@sonyv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160306222442.GA20945@sonyv> User-Agent: Mutt/1.5.23 (2014-03-12) X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Mar 06, 2016 at 11:24:44PM +0100, Laura Garcia Liebana wrote: > Add translation for icmp to nftables. Not supported types in nftables > are: any, network-unreachable, host-unreachable, protocol-unreachable, > port-unreachable, fragmentation-needed, source-route-failed, > network-unknown, host-unknown, network-prohibited, host-prohibited, > TOS-network-unreachable, TOS-host-unreachable, communication-prohibited, > host-precedence-violation, precedence-cutoff, network-redirect, > host-redirect, TOS-network-redirect, TOS-host-redirect, > router-advertisement, router-solicitation, ttl-zero-during-transit, > ttl-zero-during-reassembly, ip-header-bad and required-option-missing. Oh I see, these are actually the non-supported icmp codes at this moment, instead of the icmp types. All icmp types should work, if any missing, we should add them. For icmp codes, we need a fix for the listing side of nft. Then, please return 0 when icmp codes are specified by now, document this in the wiki and here in the description. Thanks.