From: Daniel Vetter Subject: Re: [PATCH v4 17/17] drm/i915: Split out load time interface registration Date: Tue, 15 Mar 2016 09:45:46 +0100 Message-ID: <20160315084546.GZ14170@phenom.ffwll.local> References: <1457728469-16443-1-git-send-email-imre.deak@intel.com> <1457953241-28785-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1FF26E6DF for ; Tue, 15 Mar 2016 08:44:59 +0000 (UTC) Received: by mail-wm0-x229.google.com with SMTP id l68so15407903wml.1 for ; Tue, 15 Mar 2016 01:44:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1457953241-28785-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTQsIDIwMTYgYXQgMDE6MDA6NDFQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEFjY29yZGluZyB0byB0aGUgbmV3IGluaXQgcGhhc2VzIHNjaGVtZSB3ZSBzaG91bGQgcmVn aXN0ZXIgdGhlIGRldmljZQo+IG1ha2luZyBpdCBhdmFpbGFibGUgdmlhIHNvbWUga2VybmVsIGlu dGVybmFsIG9yIHVzZXIgc3BhY2UgaW50ZXJmYWNlIGFzCj4gdGhlIGxhc3Qgc3RlcCBpbiB0aGUg aW5pdCBzZXF1ZW5jZSwgc28gbW92ZSB0aGUgY29ycmVzcG9uZGluZyBjb2RlIHRvIGEKPiBzZXBh cmF0ZSBmdW5jdGlvbi4KPiAKPiBBbHNvIGFkZCBhIFRPRE8gY29tbWVudCBhYm91dCBjb2RlIHRo YXQgc3RpbGwgbmVlZHMgdG8gYmUgbW92ZWQgYXJvdW5kCj4gdG8gb25lIG9mIHRoZSBpbml0IHBo YXNlcyBmdW5jdGlvbnMgZGVwZW5kaW5nIG9uIHdoYXQgdGhlIHJvbGUgYW5kIGVmZmVjdAo+IG9m IHRoYXQgY29kZSBpcy4KPiAKPiBObyBmdW5jdGlvbmFsIGNoYW5nZSwgZXhjZXB0IGZvciB0aGUg cmVvcmRlcmluZyBvZiB0aGUgdW5sb2FkIHRpbWUKPiB1bnJlZ2lzdHJhdGlvbiBzdGVwcyBvZiBz eXNmcyB3cnQuIGFjcGkgYW5kIG9wcmVnaW9uLgo+IAo+IFN1Z2dlc3RlZCBieSBDaHJpcy4KPiAK PiB2MzoKPiAtIHJlbmFtZSBpOTE1X2RyaXZlcl9pbml0X3JlZ2lzdGVyIHRvIGk5MTVfZHJpdmVy X2luaXRfZnJhbWV3b3Jrcwo+ICAgKENocmlzKQo+IHY0Ogo+IC0gcmVuYW1lIGk5MTVfZHJpdmVy X2luaXRfZnJhbWV3b3JrcyB0byBpOTE1X2RyaXZlcl9yZWdpc3RlciAoRGFuaWVsKQo+IAo+IEND OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDQzogRGFuaWVsIFZl dHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsg PGltcmUuZGVha0BpbnRlbC5jb20+CgpZZWFoLCB0aGlzIGJyaW5ncyB1cyBhIGxhcmdlIHN0ZXAg dG93YXJkcyBkZS1taWRsYXllcmluZyBpOTE1IGxvYWQvdW5sb2FkLApJIGxpa2UuCgpSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMgfCA4MyArKysrKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygrKSwg MjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZG1hLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jCj4gaW5kZXggYWFmMWIx Ny4uYTUxMjFjZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+IEBAIC0xMjA5LDYgKzEy MDksNTMgQEAgc3RhdGljIHZvaWQgaTkxNV9kcml2ZXJfY2xlYW51cF9odyhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIH0KPiAgCj4gIC8qKgo+ICsgKiBpOTE1X2RyaXZlcl9y ZWdpc3RlciAtIHJlZ2lzdGVyIHRoZSBkcml2ZXIgd2l0aCB0aGUgcmVzdCBvZiB0aGUgc3lzdGVt Cj4gKyAqIEBkZXZfcHJpdjogZGV2aWNlIHByaXZhdGUKPiArICoKPiArICogUGVyZm9ybSBhbnkg c3RlcHMgbmVjZXNzYXJ5IHRvIG1ha2UgdGhlIGRyaXZlciBhdmFpbGFibGUgdmlhIGtlcm5lbAo+ ICsgKiBpbnRlcm5hbCBvciB1c2Vyc3BhY2UgaW50ZXJmYWNlcy4KPiArICovCj4gK3N0YXRpYyB2 b2lkIGk5MTVfZHJpdmVyX3JlZ2lzdGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRldl9wcml2LT5kZXY7Cj4gKwo+ ICsJaTkxNV9nZW1fc2hyaW5rZXJfaW5pdChkZXZfcHJpdik7Cj4gKwkvKgo+ICsJICogTm90aWZ5 IGEgdmFsaWQgc3VyZmFjZSBhZnRlciBtb2Rlc2V0dGluZywKPiArCSAqIHdoZW4gcnVubmluZyBp bnNpZGUgYSBWTS4KPiArCSAqLwo+ICsJaWYgKGludGVsX3ZncHVfYWN0aXZlKGRldikpCj4gKwkJ STkxNV9XUklURSh2Z3RpZl9yZWcoZGlzcGxheV9yZWFkeSksIFZHVF9EUlZfRElTUExBWV9SRUFE WSk7Cj4gKwo+ICsJaTkxNV9zZXR1cF9zeXNmcyhkZXYpOwo+ICsKPiArCWlmIChJTlRFTF9JTkZP KGRldl9wcml2KS0+bnVtX3BpcGVzKSB7Cj4gKwkJLyogTXVzdCBiZSBkb25lIGFmdGVyIHByb2Jp bmcgb3V0cHV0cyAqLwo+ICsJCWludGVsX29wcmVnaW9uX2luaXQoZGV2KTsKPiArCQlhY3BpX3Zp ZGVvX3JlZ2lzdGVyKCk7Cj4gKwl9Cj4gKwo+ICsJaWYgKElTX0dFTjUoZGV2X3ByaXYpKQo+ICsJ CWludGVsX2dwdV9pcHNfaW5pdChkZXZfcHJpdik7Cj4gKwo+ICsJaTkxNV9hdWRpb19jb21wb25l bnRfaW5pdChkZXZfcHJpdik7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBpOTE1X2RyaXZlcl91bnJl Z2lzdGVyIC0gY2xlYW51cCB0aGUgcmVnaXN0cmF0aW9uIGRvbmUgaW4gaTkxNV9kcml2ZXJfcmVn aXNlcigpCj4gKyAqIEBkZXZfcHJpdjogZGV2aWNlIHByaXZhdGUKPiArICovCj4gK3N0YXRpYyB2 b2lkIGk5MTVfZHJpdmVyX3VucmVnaXN0ZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICt7Cj4gKwlpOTE1X2F1ZGlvX2NvbXBvbmVudF9jbGVhbnVwKGRldl9wcml2KTsKPiAr CWludGVsX2dwdV9pcHNfdGVhcmRvd24oKTsKPiArCWFjcGlfdmlkZW9fdW5yZWdpc3RlcigpOwo+ ICsJaW50ZWxfb3ByZWdpb25fZmluaShkZXZfcHJpdi0+ZGV2KTsKPiArCWk5MTVfdGVhcmRvd25f c3lzZnMoZGV2X3ByaXYtPmRldik7Cj4gKwlpOTE1X2dlbV9zaHJpbmtlcl9jbGVhbnVwKGRldl9w cml2KTsKPiArfQo+ICsKPiArLyoqCj4gICAqIGk5MTVfZHJpdmVyX2xvYWQgLSBzZXR1cCBjaGlw IGFuZCBjcmVhdGUgYW4gaW5pdGlhbCBjb25maWcKPiAgICogQGRldjogRFJNIGRldmljZQo+ICAg KiBAZmxhZ3M6IHN0YXJ0dXAgZmxhZ3MKPiBAQCAtMTI0Niw2ICsxMjkzLDExIEBAIGludCBpOTE1 X2RyaXZlcl9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGxvbmcgZmxhZ3Mp Cj4gIAlpZiAocmV0IDwgMCkKPiAgCQlnb3RvIG91dF9jbGVhbnVwX21taW87Cj4gIAo+ICsJLyoK PiArCSAqIFRPRE86IG1vdmUgdGhlIHZibGFuayBpbml0IGFuZCBwYXJ0cyBvZiBtb2Rlc2V0IGlu aXQgc3RlcHMgaW50byBvbmUKPiArCSAqIG9mIHRoZSBpOTE1X2RyaXZlcl9pbml0Xy9pOTE1X2Ry aXZlcl9yZWdpc3RlciBmdW5jdGlvbnMgYWNjb3JkaW5nCj4gKwkgKiB0byB0aGUgcm9sZS9lZmZl Y3Qgb2YgdGhlIGdpdmVuIGluaXQgc3RlcC4KPiArCSAqLwo+ICAJaWYgKElOVEVMX0lORk8oZGV2 KS0+bnVtX3BpcGVzKSB7Cj4gIAkJcmV0ID0gZHJtX3ZibGFua19pbml0KGRldiwgSU5URUxfSU5G TyhkZXYpLT5udW1fcGlwZXMpOwo+ICAJCWlmIChyZXQpCj4gQEAgLTEyNTgsMjYgKzEzMTAsNyBA QCBpbnQgaTkxNV9kcml2ZXJfbG9hZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBs b25nIGZsYWdzKQo+ICAJCWdvdG8gb3V0X3Bvd2VyX3dlbGw7Cj4gIAl9Cj4gIAo+IC0JaTkxNV9n ZW1fc2hyaW5rZXJfaW5pdChkZXZfcHJpdik7Cj4gLQkvKgo+IC0JICogTm90aWZ5IGEgdmFsaWQg c3VyZmFjZSBhZnRlciBtb2Rlc2V0dGluZywKPiAtCSAqIHdoZW4gcnVubmluZyBpbnNpZGUgYSBW TS4KPiAtCSAqLwo+IC0JaWYgKGludGVsX3ZncHVfYWN0aXZlKGRldikpCj4gLQkJSTkxNV9XUklU RSh2Z3RpZl9yZWcoZGlzcGxheV9yZWFkeSksIFZHVF9EUlZfRElTUExBWV9SRUFEWSk7Cj4gLQo+ IC0JaTkxNV9zZXR1cF9zeXNmcyhkZXYpOwo+IC0KPiAtCWlmIChJTlRFTF9JTkZPKGRldiktPm51 bV9waXBlcykgewo+IC0JCS8qIE11c3QgYmUgZG9uZSBhZnRlciBwcm9iaW5nIG91dHB1dHMgKi8K PiAtCQlpbnRlbF9vcHJlZ2lvbl9pbml0KGRldik7Cj4gLQkJYWNwaV92aWRlb19yZWdpc3Rlcigp Owo+IC0JfQo+IC0KPiAtCWlmIChJU19HRU41KGRldikpCj4gLQkJaW50ZWxfZ3B1X2lwc19pbml0 KGRldl9wcml2KTsKPiAtCj4gLQlpOTE1X2F1ZGlvX2NvbXBvbmVudF9pbml0KGRldl9wcml2KTsK PiArCWk5MTVfZHJpdmVyX3JlZ2lzdGVyKGRldl9wcml2KTsKPiAgCj4gIAlpbnRlbF9ydW50aW1l X3BtX2VuYWJsZShkZXZfcHJpdik7Cj4gIAo+IEBAIC0xMzE2LDE1ICsxMzQ5LDcgQEAgaW50IGk5 MTVfZHJpdmVyX3VubG9hZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgCWludGVsX2Rp c3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBQT1dFUl9ET01BSU5fSU5JVCk7Cj4gIAo+IC0JaTkx NV9hdWRpb19jb21wb25lbnRfY2xlYW51cChkZXZfcHJpdik7Cj4gLQo+IC0JaW50ZWxfZ3B1X2lw c190ZWFyZG93bigpOwo+IC0KPiAtCWk5MTVfdGVhcmRvd25fc3lzZnMoZGV2KTsKPiAtCj4gLQlh Y3BpX3ZpZGVvX3VucmVnaXN0ZXIoKTsKPiAtCWludGVsX29wcmVnaW9uX2ZpbmkoZGV2KTsKPiAt CWk5MTVfZ2VtX3Nocmlua2VyX2NsZWFudXAoZGV2X3ByaXYpOwo+ICsJaTkxNV9kcml2ZXJfdW5y ZWdpc3RlcihkZXZfcHJpdik7Cj4gIAo+ICAJZHJtX3ZibGFua19jbGVhbnVwKGRldik7Cj4gIAo+ IC0tIAo+IDIuNS4wCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==