Return-Path: Received: from mx2.suse.de ([195.135.220.15]:54139 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbcCWJpZ (ORCPT ); Wed, 23 Mar 2016 05:45:25 -0400 Date: Wed, 23 Mar 2016 10:45:51 +0100 From: Jan Kara To: Toshi Kani Cc: Ross Zwisler , Jan Kara , linux-nvdimm@lists.01.org, NeilBrown , "Wilcox, Matthew R" , linux-fsdevel@vger.kernel.org, brian.boylston@hpe.com Subject: Re: [RFC v2] [PATCH 0/10] DAX page fault locking Message-ID: <20160323094551.GA4512@quack.suse.cz> References: <1458566575-28063-1-git-send-email-jack@suse.cz> <20160322193212.GA11164@linux.intel.com> <1458680853.6393.592.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1458680853.6393.592.camel@hpe.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue 22-03-16 15:07:33, Toshi Kani wrote: > On Tue, 2016-03-22 at 13:32 -0600, Ross Zwisler wrote: > > On Mon, Mar 21, 2016 at 02:22:45PM +0100, Jan Kara wrote: > > > [Sorry for repost but I accidentally sent initial email without > > > patches] > > > > > > Hello, > > > > > > this is my second attempt at DAX page fault locking rewrite. Things now > > > work reasonably well, it has survived full xfstests run on ext4. I > > > guess I need to do more mmap targetted tests to unveil issues. Guys > > > what do you used for DAX testing? > > > > I typically use xfstests for regression testing.��If we can come up with > > new generally useful regression tests, especially ones concerning mmap > > races, that would be awesome.��I guess it's just a choice between adding > > them somewhere in xfstests or somewhere else like with the unit tests in > > ndctl. > > Brian Boylston wrote a test for mmap race conditions and posted it before. > �This test was very useful to fix the data corruption issue we had before. > http://www.spinics.net/lists/linux-ext4/msg49876.html > > If there is anything we can do to make this test useful as regression > tests? Thanks for the pointer, I forgot about this useful test. As Dave said the best way for this to not get lost is to include it in xfstests. Since I want to run the test regularly anyway, I can integrate it myself. Honza -- Jan Kara SUSE Labs, CR