Received: from eggs.gnu.org ([2001:4830:134:3::10]:56469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axaTY-0006jS-3h for qemu-devel@nongnu.org; Tue, 03 May 2016 09:35:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axaTM-00063t-Gl for qemu-devel@nongnu.org; Tue, 03 May 2016 09:34:50 -0400 Date: Tue, 3 May 2016 15:34:08 +0200 From: Kevin Wolf Message-ID: <20160503133408.GG3917@noname.str.redhat.com> References: <1461706338-20219-1-git-send-email-mreitz@redhat.com> <1461706338-20219-3-git-send-email-mreitz@redhat.com> <20160502153555.GH4882@noname.redhat.com> <57288238.4060302@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VV4b6MQE+OnNyhkM" Content-Disposition: inline In-Reply-To: <57288238.4060302@redhat.com> Subject: Re: [Qemu-devel] [PATCH 02/19] block: Add BDS.backing_overridden List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Alberto Garcia , Eric Blake --VV4b6MQE+OnNyhkM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 03.05.2016 um 12:49 hat Max Reitz geschrieben: > On 02.05.2016 17:35, Kevin Wolf wrote: > > Am 26.04.2016 um 23:32 hat Max Reitz geschrieben: > >> If the backing file is overridden, this most probably does change the > >> guest-visible data of a BDS. Therefore, we will need to consider this = in > >> bdrv_refresh_filename(). > >> > >> Adding a new field to the BDS is not nice, but it is very simple and > >> exactly keeps track of whether the backing file has been overridden. > >> > >> Signed-off-by: Max Reitz > >=20 > > What about live snapshots or block jobs that manipulate bs->backing? > > They don't use bdrv_open_backing_file(), but bdrv_append() or > > bdrv_replace_in_backing_chain() in order to assign a backing file, which > > may or may not be the same as in the image header. >=20 > I'll take a look into each case, thanks. >=20 > > Also, do we want to consider a backing file overridden when the user > > specified it explicitly, but it matches the image header? >=20 > For simplicity's sake, I would. I think we've realized before that > trying to identify whether to file names point to the same image is > rather difficult. I was just asking because in that case, we probably must consider things like the backing file of a live snapshot overlay overridden as well (at least when using an existing image). Kevin --VV4b6MQE+OnNyhkM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXKKjPAAoJEH8JsnLIjy/WnyQP/0ARBPhTUXPv6XstdT4zZXaj YOrRaGSOqun3V1FVcPgrVEtlZAbSSwQaNa1GT1whJXgggyPI97zOow+VAqyOIhxb PQbyMkmgdR+I+xwkoFWR5yMtOPvK3WGqYIP5UKUmoWBM0QYhuQxwiBR+IZ+vnDJ+ xRDcLAgpF69euKHs8/n/WVg9yj0meEvnX97KaWsthUVAAaumPCGZs7X/AHydLnda GyHTnBevkbQUKTJfh30mQYGlB/KhhsSPix8K3VGuCDwycvgZKoPkAy+G5wd+eIYV /jvned51aKRqWfnBkUzbTJAzCbH+HJqFBV80j6hEJ44hKKE6kYvufjwl57vbSkll nGokSh0UPpIs/k+tChTSumqfQrltxHlLM+uMUjHfptmq30yh+2ti/vZK0m+niOfN lOGCkTsZn9yRiYfskZM3H5G2UTOOg9rhPLemlRunLLVfkPujemG4YCxI29J45hO2 R9CHhVnQc9LpYDVFnPUygy7E1iFxnf3eLB6+24j83FF26cDQEBJZGM9W0VbLRIy0 KJ8Jk1PN0XXQz8Txy6Trrz+CphN6YofJQ3MmW6t8n2QAUu2H9/3be4W9pnom52bx 4lqGSh2miS1WHoq8RWM2HyPw5w/VyEutt4qrFnU6S0n4sFptZ6cRsoWHOI9mK6Hz 6YXKLw+C0TzqqsngcgcK =IB65 -----END PGP SIGNATURE----- --VV4b6MQE+OnNyhkM--