Reply-To: kernel-hardening@lists.openwall.com Date: Tue, 10 May 2016 13:21:57 +0200 From: Borislav Petkov Message-ID: <20160510112157.GB28520@pd.tnic> References: <1462825332-10505-1-git-send-email-keescook@chromium.org> <1462825332-10505-2-git-send-email-keescook@chromium.org> <20160510055853.GA2293@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160510055853.GA2293@gmail.com> Subject: [kernel-hardening] Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time To: Ingo Molnar Cc: Yinghai Lu , Kees Cook , Baoquan He , Ingo Molnar , "H. Peter Anvin" , Vivek Goyal , Andy Lutomirski , Lasse Collin , Andrew Morton , Dave Young , "kernel-hardening@lists.openwall.com" , LKML , Linus Torvalds List-ID: On Tue, May 10, 2016 at 07:58:54AM +0200, Ingo Molnar wrote: > Ok, could you guys please update the code and the changelog as well, > and also rename that horribly named prepare_level4() function? Oh, and while at it, call that new function at the beginning of choose_random_location() before the first call to add_identity_map() through mem_avoid_init() and make the code flow even clearer this way instead of doing funky checks like if (!level4p) prepare_level4(); Thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --