Date: Mon, 16 May 2016 20:20:38 +0200 (CEST) Message-Id: <201605161820.u4GIKcR0032755@...2054...> From: Gert Doering In-Reply-To: <1457671646-4322-1-git-send-email-selva.nair@...277...> References: <1457671646-4322-1-git-send-email-selva.nair@...277...> Subject: [Openvpn-devel] [PATCH applied] Re: Add support for register-dns through interactive service List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: openvpn-devel@lists.sourceforge.net ACK. Thanks a lot, and sorry for the delay in reviewing. I've stared at the code, and it looks good to me (very clean code, if I may say so :-) ) - the openvpn code is definitely good, the iservice code "looks reasonable", though I might be missing some windows intricacies. Compile-tested on my mingw test environment, but have not run it yet - I'm going to be lazy and wait for Samuli's build snapshot. Your patch has been applied to the master branch. commit 3e42a558103e4e3f45ed28ccb761cefed20e8247 (master) Author: Selva Nair Date: Thu Mar 10 23:47:26 2016 -0500 Add support for register-dns through interactive service Signed-off-by: Selva Nair Acked-by: Gert Doering Message-Id: <1457671646-4322-1-git-send-email-selva.nair@...277...> URL: http://article.gmane.org/gmane.network.openvpn.devel/11354 Signed-off-by: Gert Doering -- kind regards, Gert Doering