From: Marius Vlad Subject: Re: [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module. Date: Mon, 23 May 2016 13:43:42 +0300 Message-ID: <20160523104341.GA2369@mcvlad-wk.rb.intel.com> References: <1463757605-27042-1-git-send-email-marius.c.vlad@intel.com> <1463760018.31501.25.camel@intel.com> <20160520162356.GX3590@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0694716401==" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 4488F6E569 for ; Mon, 23 May 2016 10:40:48 +0000 (UTC) In-Reply-To: <20160520162356.GX3590@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0694716401== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 20, 2016 at 05:23:56PM +0100, Chris Wilson wrote: > On Fri, May 20, 2016 at 07:00:18PM +0300, Imre Deak wrote: > > On pe, 2016-05-20 at 18:20 +0300, Marius Vlad wrote: > > > Either we return $IGT_EXIT_FAILURE or remove it entirely (like in > > > this > > > patch). If rmmod returns non-zero (i.e., Module: i915 is still in > > > use), reload > > > will bail with $IGT_EXIT_SKIP, making the check with lsmod useless. > > > Also use the return value in the fault-injection loop. > > >=20 > > > Signed-off-by: Marius Vlad > > > --- > > > =A0tests/drv_module_reload_basic | 4 ++-- > > > =A01 file changed, 2 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/tests/drv_module_reload_basic > > > b/tests/drv_module_reload_basic > > > index 3bba796..3a8df33 100755 > > > --- a/tests/drv_module_reload_basic > > > +++ b/tests/drv_module_reload_basic > > > @@ -30,7 +30,7 @@ function reload() { > > > =A0 > > > =A0 #ignore errors in ips - gen5 only > > > =A0 rmmod intel_ips &> /dev/null > > > - rmmod i915 || return $IGT_EXIT_SKIP > > > + rmmod i915 > >=20 > > Not sure what was the reason to bail out here, continuing seems like > > the correct thing to do. >=20 > If we can't unload, we can perform the modprobe testing. The system is > not in a state suitable for testing so skip or fail. If we are certain > that the rmmod failure is a bug, fail, if it merely something like the > system doesn't support module unloading, skip. I've seen this couple of times in the CI...and went mostly mostly unnoticed, wanted to make it hard-fail so it easy to spot when it happens again. Although it might be cases where the module is built-in this is not the case in CI. >=20 > Continuing on after failure to unload is not a good idea. > -Chris >=20 > --=20 > Chris Wilson, Intel Open Source Technology Centre --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXQt7dAAoJELmLWIAQzyE+J8EH/A/AtumVuV6wzbIWGplB9Lp+ zXdim7SrZ3N+bxj2m1BeBkh5W4OjXoCkYxzJWzRI4m4bYcKQn9lCKerYpWGYCybs 9soyu+9uA7KUn10iRBF1/GRyXLtcXH0jFZ7yAY3Xg7aAibJC5Nx7reWBglMXct7Q VpviDdml8UfEe9pEZnZGzUk5XN5InDfxv9FikuCsOpNKaQ1Fe31Vw2ESI1DKM9L9 EWk5jO04Euav62kl0pBnJuC2HHDuX3WCfpkMZbEig6tHqStt1JfvA+kinKKhxIN5 G4v+5fUVfEtCGpHfEsEZbMPEWZ10R+E7Kt+RE5TZuMYb7QQkMVUV3CDOXHAvHC4= =L34E -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE-- --===============0694716401== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0694716401==--