From: Marius Vlad Subject: Re: [PATCH i-g-t v5 0/7] kms_flip_event_leak and kms_vblank fixes for Date: Tue, 24 May 2016 14:19:25 +0300 Message-ID: <20160524111925.GA4955@mcvlad-wk.rb.intel.com> References: <1463405912-1592-1-git-send-email-robert.foss@collabora.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0955803933==" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 79B3E6E720 for ; Tue, 24 May 2016 11:15:58 +0000 (UTC) In-Reply-To: <1463405912-1592-1-git-send-email-robert.foss@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: robert.foss@collabora.com Cc: daniel.stone@collabora.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0955803933== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, I'm getting mixed results w/ this series applied. The kernel seems to trip in different ways either from suspend or on reload (running the BAT suite on a HSW machine), and though it seems totally unrelated I can't reproduce the same behaviour without the series applied. Haven't managed to get some valid output as the machine dead-locks/freezes, so please be patient until I try to isolate the problem. It could be I stumbled something totally unrelated. On Mon, May 16, 2016 at 09:38:25AM -0400, robert.foss@collabora.com wrote: > From: Robert Foss >=20 > In addition to the changes made in v4, danvet suggested that the argument= for > the (newly renamed) helper function kmstest_get_vbl_flag should be change= d. >=20 > I investigated it and found that all of the places where the helper funct= ion > currently is used, would require more of a rework with changed arguments = than > with unchanged arguments, so I decided to not change the arguments. >=20 > Changes since v1: > - kms_vblank: Removed un-used members of data_t struct. > - Rename plane_counter to n_planes. > - Removed un-needed handling CURSOR plane location. > - Added names for additional planes in update kmstest_plane_name. >=20 > Changes since v2: > - Rebased onto trunk which already contains kms_flip_event_leak changes. >=20 > Changes since v3: > - kms_vblank.c: Removed drm_fd from data_t, to decrease the number of > unrelated changes in the patch. > - kms_vblank.c: Changed "int valid_tests" to "unsigned valid_tests". > - kms_vblank.c: Changed crtc_id_flag/crtc_id_to_flag to > pipe_id_flag/pipe_id_to_flag. > - kms_vblank.c: Changed to "vbl.request.type |=3D crtc_id_flag;". > - kms_vblank.c: Moved crtc_id_to_flag to igt_kms.c. > - kms_vblank.c: Renamed crtc_id_to_flag to pipe_id_to_vbl_flag. > - kms_flip.c: Changed test busy_mode boolean into mode_busy bitfield in s= truct > data. > - igt_kms.h: Moved IGT_PLANE_CURSOR position comment. >=20 > Changes since v4: > - kms_vblank.c: Removed whitespace at end of file. > - igt_kms: Changed name of helper function to kmstest_get_vbl_flag > - igt_kms: Changed kmstest_get_vbl_flag to not set DRM_VBLANK_RELATIVE fl= ag >=20 > Robert Foss (7): > lib/igt_kms: Add support for up to 10 planes. > lib/igt_kms: Fix plane counting in igt_display_init. > lib/igt_kms: Switch to verbose assert. > lib/igt_kms: Added pipe_id_to_vbl_flag() to igt_kms. > kms_vblank: Switch from using crtc0 statically to explicitly setting > mode. > igt_kms: Change igt_wait_for_vblank to use helper function. > kms_flip: Change __wait_for_vblank to use helper function. >=20 > lib/igt_kms.c | 36 ++++++++++-- > lib/igt_kms.h | 9 ++- > tests/kms_flip.c | 8 +-- > tests/kms_vblank.c | 161 ++++++++++++++++++++++++++++++++++++++++++++---= ------ > 4 files changed, 179 insertions(+), 35 deletions(-) >=20 > --=20 > 2.7.4 >=20 --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXRDi9AAoJELmLWIAQzyE+2PgH+gOISmOAe60Bm6YVYIee6TIp UoOOsWGVygiuLre+K9oGijfStyEis9fygcJJticlmn3xZlc1tRRdjsCxO7v+9yXj 5YCIlRIRNTbfTgxWY0hrqwmHmH0O80GbZbF5mPRtqcfuUAgClG9QHwuBJ2ZXjii1 2vw8TuarWRglBwvg/XqSB2VJL4t8GWMQu+SlTaNZjOwA0MJ6PrM5PNVjOvQ99NZi 5oBi3WQtI/ibYsZxZuynsEoXymb5VB0wDTWQbmU/EbZEFRPABiNYJa3VzNkgQfZN vz4bdXa3eqt5mKtR4/MsAq02sWmZsIHHGDaMfizwswOBO4Ht+dqZvCabdzkPKLo= =4LKK -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH-- --===============0955803933== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0955803933==--