From: Daniel Vetter Subject: Re: [PATCH v2 18/21] drm/i915: Make unpin async. Date: Tue, 24 May 2016 16:00:50 +0200 Message-ID: <20160524140050.GX27098@phenom.ffwll.local> References: <1463490484-19540-1-git-send-email-maarten.lankhorst@linux.intel.com> <1463490484-19540-19-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 373766E799 for ; Tue, 24 May 2016 14:00:51 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id f75so6455824wmf.2 for ; Tue, 24 May 2016 07:00:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1463490484-19540-19-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMTcsIDIwMTYgYXQgMDM6MDg6MDFQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQWxsIG9mIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlIGlzIGhhbmRsZWQgdGhl cmUgbm93LCBzbyBtb3ZlIGl0IG92ZXIuCj4gVGhpcyBpcyBydW4gYWZ0ZXIgdGhlIGh3IHN0YXRl IGNoZWNrZXIgYmVjYXVzZSBpdCBjYW4ndCBoYW5kbGUgY2hlY2tpbmcKPiBjcnRjJ3Mgc2VwYXJh dGVseSB5ZXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KCkZpcnN0IHRoaXMgcGF0Y2ggaXMgbWFzc2l2ZSwg YW5kIGltbyB0b28gYmlnIGFuZCBzaG91bGQgaGF2ZSBiZWVuIHNwbGl0CnVwLgoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMgIHwgIDExICsrCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM0NCArKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAg IDUgKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAyMjggaW5zZXJ0aW9ucygrKSwgMTMyIGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4gaW5kZXggNTBmZjkwYWVh NzIxLi5iNDkyN2Y2YmJlYWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXRvbWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+ IEBAIC0zMTEsNiArMzExLDE3IEBAIGludGVsX2F0b21pY19zdGF0ZV9hbGxvYyhzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KQo+ICB2b2lkIGludGVsX2F0b21pY19zdGF0ZV9jbGVhcihzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqcykKPiAgewo+ICAJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3Rh dGUgPSB0b19pbnRlbF9hdG9taWNfc3RhdGUocyk7Cj4gKwlpbnQgaTsKPiArCj4gKwlmb3IgKGkg PSAwOyBpIDwgQVJSQVlfU0laRShzdGF0ZS0+d29yayk7IGkrKykgewo+ICsJCXN0cnVjdCBpbnRl bF9mbGlwX3dvcmsgKndvcmsgPSBzdGF0ZS0+d29ya1tpXTsKPiArCj4gKwkJaWYgKHdvcmspCj4g KwkJCWludGVsX2ZyZWVfZmxpcF93b3JrKHdvcmspOwo+ICsKPiArCQlzdGF0ZS0+d29ya1tpXSA9 IE5VTEw7Cj4gKwl9Cj4gKwo+ICAJZHJtX2F0b21pY19zdGF0ZV9kZWZhdWx0X2NsZWFyKCZzdGF0 ZS0+YmFzZSk7Cj4gIAlzdGF0ZS0+ZHBsbF9zZXQgPSBzdGF0ZS0+bW9kZXNldCA9IGZhbHNlOwo+ ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDY5YWJjODA4YTJj NC4uMTZkOGUyOTk5OTRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IEBAIC00NTM3LDM5ICs0NTM3LDYgQEAgaW50ZWxfcHJlX2Rpc2FibGVfcHJpbWFyeV9ub2F0b21p YyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAl9Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGlu dGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19z dGF0ZSkKPiAtewo+IC0Jc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKG9s ZF9jcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+IC0Jc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKm9s ZF9zdGF0ZSA9IG9sZF9jcnRjX3N0YXRlLT5iYXNlLnN0YXRlOwo+IC0Jc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKnBpcGVfY29uZmlnID0KPiAtCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJh c2Uuc3RhdGUpOwo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+ IC0Jc3RydWN0IGRybV9wbGFuZSAqcHJpbWFyeSA9IGNydGMtPmJhc2UucHJpbWFyeTsKPiAtCXN0 cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9wcmlfc3RhdGUgPQo+IC0JCWRybV9hdG9taWNfZ2V0 X2V4aXN0aW5nX3BsYW5lX3N0YXRlKG9sZF9zdGF0ZSwgcHJpbWFyeSk7Cj4gLQo+IC0JaW50ZWxf ZnJvbnRidWZmZXJfZmxpcChkZXYsIHBpcGVfY29uZmlnLT5mYl9iaXRzKTsKPiAtCj4gLQljcnRj LT53bS5jeHNyX2FsbG93ZWQgPSB0cnVlOwo+IC0KPiAtCWlmIChwaXBlX2NvbmZpZy0+dXBkYXRl X3dtX3Bvc3QgJiYgcGlwZV9jb25maWctPmJhc2UuYWN0aXZlKQo+IC0JCWludGVsX3VwZGF0ZV93 YXRlcm1hcmtzKCZjcnRjLT5iYXNlKTsKPiAtCj4gLQlpZiAob2xkX3ByaV9zdGF0ZSkgewo+IC0J CXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcHJpbWFyeV9zdGF0ZSA9Cj4gLQkJCXRvX2ludGVs X3BsYW5lX3N0YXRlKHByaW1hcnktPnN0YXRlKTsKPiAtCQlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3Rh dGUgKm9sZF9wcmltYXJ5X3N0YXRlID0KPiAtCQkJdG9faW50ZWxfcGxhbmVfc3RhdGUob2xkX3By aV9zdGF0ZSk7Cj4gLQo+IC0JCWludGVsX2ZiY19wb3N0X3VwZGF0ZShjcnRjKTsKPiAtCj4gLQkJ aWYgKHByaW1hcnlfc3RhdGUtPnZpc2libGUgJiYKPiAtCQkgICAgKG5lZWRzX21vZGVzZXQoJnBp cGVfY29uZmlnLT5iYXNlKSB8fAo+IC0JCSAgICAgIW9sZF9wcmltYXJ5X3N0YXRlLT52aXNpYmxl KSkKPiAtCQkJaW50ZWxfcG9zdF9lbmFibGVfcHJpbWFyeSgmY3J0Yy0+YmFzZSk7Cj4gLQl9Cj4g LX0KClRoZSBhYm92ZSBzZWVtcyB0byBoYXZlIG1vdmVkL2Rpc2FwcGVhcmVkIGVudGlyZWx5LCBh bmQgaXMgZGVmaW5pdGVseSBub3QKdW5waW4gcmVsYXRlZC4gUmVhbGx5LCB0aGlzIG11c3QgYmUg c3BsaXQgdXAuIEkgZ3Vlc3MgYW5vdGhlciByZWFzb24gdG8KcmV2ZXJ0IHRoaXMgZm9yIG5vdy4K Ck9yIGF0IGxlYXN0IHRoZSBjb21taXQgc2hvdWxkIGhhdmUgYSBtb3JlIGFjY3VyYXRlIHN1bW1h cnkuIEJ1dCBzaW5jZSBJCmNhbid0IGV2ZW4gZmluZCB0aGUgbmV3IGNhbGxzaXRlIG9mIHRoZXNl IGZ1bmN0aW9ucyBpbiB0aGlzIGRpZmYgaGVyZQpzb21ldGhpbmcgc2VlbXMgZmlzaHksIGJ1dCBJ IGRpZG4ndCBsb29rIGF0IHRoZSBlbnRpcmUgc2VyaWVzLgoKQW55d2F5LCB3aXRoIHRoYXQgcmFu dCBvdXQgb2YgdGhlIHdheSBzZWUgYmVsb3cgZm9yIHdoYXQgSSByZWFsbHkgd2FudGVkCnRvIGNv bW1lbnQgb24uCgoKW3NuaXBdCgo+ICtzdGF0aWMgdm9pZCBpbnRlbF9wcmVwYXJlX3dvcmsoc3Ry dWN0IGRybV9jcnRjICpjcnRjLAo+ICsJCQkgICAgICAgc3RydWN0IGludGVsX2ZsaXBfd29yayAq d29yaywKPiArCQkJICAgICAgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJ ICAgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUpCj4gIHsKPiAtCXVu c2lnbmVkIGxhc3RfdmJsYW5rX2NvdW50W0k5MTVfTUFYX1BJUEVTXTsKPiAtCWVudW0gcGlwZSBw aXBlOwo+IC0JaW50IHJldDsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9f aW50ZWxfY3J0YyhjcnRjKTsKPiArCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9wbGFuZV9z dGF0ZTsKPiArCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ICsJaW50IGksIGogPSAwOwo+ICAK PiAtCWlmICghY3J0Y19tYXNrKQo+IC0JCXJldHVybjsKPiArCUlOSVRfV09SSygmd29yay0+dW5w aW5fd29yaywgaW50ZWxfdW5waW5fd29ya19mbik7Cj4gKwlJTklUX1dPUksoJndvcmstPm1taW9f d29yaywgaW50ZWxfbW1pb19mbGlwX3dvcmtfZnVuYyk7Cj4gKwlhdG9taWNfaW5jKCZpbnRlbF9j cnRjLT51bnBpbl93b3JrX2NvdW50KTsKPiAgCj4gLQlmb3JfZWFjaF9waXBlKGRldl9wcml2LCBw aXBlKSB7Cj4gLQkJc3RydWN0IGRybV9jcnRjICpjcnRjID0gZGV2X3ByaXYtPnBpcGVfdG9fY3J0 Y19tYXBwaW5nW3BpcGVdOwo+ICsJZm9yX2VhY2hfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5l LCBvbGRfcGxhbmVfc3RhdGUsIGkpIHsKPiArCQlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKm9s ZF9zdGF0ZSA9IHRvX2ludGVsX3BsYW5lX3N0YXRlKG9sZF9wbGFuZV9zdGF0ZSk7Cj4gKwkJc3Ry dWN0IGludGVsX3BsYW5lX3N0YXRlICpuZXdfc3RhdGUgPSB0b19pbnRlbF9wbGFuZV9zdGF0ZShw bGFuZS0+c3RhdGUpOwo+ICAKPiAtCQlpZiAoISgoMSA8PCBwaXBlKSAmIGNydGNfbWFzaykpCj4g KwkJaWYgKG9sZF9zdGF0ZS0+YmFzZS5jcnRjICE9IGNydGMgJiYKPiArCQkgICAgbmV3X3N0YXRl LT5iYXNlLmNydGMgIT0gY3J0YykKPiAgCQkJY29udGludWU7Cj4gIAo+IC0JCXJldCA9IGRybV9j cnRjX3ZibGFua19nZXQoY3J0Yyk7Cj4gLQkJaWYgKFdBUk5fT04ocmV0ICE9IDApKSB7Cj4gLQkJ CWNydGNfbWFzayAmPSB+KDEgPDwgcGlwZSk7Cj4gLQkJCWNvbnRpbnVlOwo+ICsJCWlmIChwbGFu ZS0+dHlwZSA9PSBEUk1fUExBTkVfVFlQRV9QUklNQVJZKSB7Cj4gKwkJCXBsYW5lLT5mYiA9IG5l d19zdGF0ZS0+YmFzZS5mYjsKPiArCQkJY3J0Yy0+eCA9IG5ld19zdGF0ZS0+YmFzZS5zcmNfeCA+ PiAxNjsKPiArCQkJY3J0Yy0+eSA9IG5ld19zdGF0ZS0+YmFzZS5zcmNfeSA+PiAxNjsKPiAgCQl9 Cj4gIAo+IC0JCWxhc3RfdmJsYW5rX2NvdW50W3BpcGVdID0gZHJtX2NydGNfdmJsYW5rX2NvdW50 KGNydGMpOwo+ICsJCW9sZF9zdGF0ZS0+d2FpdF9yZXEgPSBuZXdfc3RhdGUtPndhaXRfcmVxOwo+ ICsJCW5ld19zdGF0ZS0+d2FpdF9yZXEgPSBOVUxMOwo+ICsKPiArCQlvbGRfc3RhdGUtPmJhc2Uu ZmVuY2UgPSBuZXdfc3RhdGUtPmJhc2UuZmVuY2U7Cj4gKwkJbmV3X3N0YXRlLT5iYXNlLmZlbmNl ID0gTlVMTDsKPiArCj4gKwkJLyogcmVtb3ZlIHBsYW5lIHN0YXRlIGZyb20gdGhlIGF0b21pYyBz dGF0ZSBhbmQgbW92ZSBpdCB0byB3b3JrICovCj4gKwkJb2xkX3BsYW5lX3N0YXRlLT5zdGF0ZSA9 IE5VTEw7Cj4gKwkJc3RhdGUtPnBsYW5lc1tpXSA9IE5VTEw7Cj4gKwkJc3RhdGUtPnBsYW5lX3N0 YXRlc1tpXSA9IE5VTEw7Cj4gKwo+ICsJCXdvcmstPm9sZF9wbGFuZV9zdGF0ZVtqXSA9IG9sZF9z dGF0ZTsKPiArCQl3b3JrLT5uZXdfcGxhbmVfc3RhdGVbaisrXSA9IG5ld19zdGF0ZTsKPiAgCX0K PiAgCj4gLQlmb3JfZWFjaF9waXBlKGRldl9wcml2LCBwaXBlKSB7Cj4gLQkJc3RydWN0IGRybV9j cnRjICpjcnRjID0gZGV2X3ByaXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW3BpcGVdOwo+IC0JCWxv bmcgbHJldDsKPiArCW9sZF9jcnRjX3N0YXRlLT5zdGF0ZSA9IE5VTEw7Cj4gKwlzdGF0ZS0+Y3J0 Y3NbZHJtX2NydGNfaW5kZXgoY3J0YyldID0gTlVMTDsKPiArCXN0YXRlLT5jcnRjX3N0YXRlc1tk cm1fY3J0Y19pbmRleChjcnRjKV0gPSBOVUxMOwo+ICAKPiAtCQlpZiAoISgoMSA8PCBwaXBlKSAm IGNydGNfbWFzaykpCj4gLQkJCWNvbnRpbnVlOwo+ICsJd29yay0+b2xkX2NydGNfc3RhdGUgPSB0 b19pbnRlbF9jcnRjX3N0YXRlKG9sZF9jcnRjX3N0YXRlKTsKPiArCXdvcmstPm5ld19jcnRjX3N0 YXRlID0gdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSk7Cj4gKwl3b3JrLT5udW1fcGxh bmVzID0gajsKPiAgCj4gLQkJbHJldCA9IHdhaXRfZXZlbnRfdGltZW91dChkZXYtPnZibGFua1tw aXBlXS5xdWV1ZSwKPiAtCQkJCWxhc3RfdmJsYW5rX2NvdW50W3BpcGVdICE9Cj4gLQkJCQkJZHJt X2NydGNfdmJsYW5rX2NvdW50KGNydGMpLAo+IC0JCQkJbXNlY3NfdG9famlmZmllcyg1MCkpOwo+ ICsJd29yay0+ZXZlbnQgPSBjcnRjLT5zdGF0ZS0+ZXZlbnQ7Cj4gKwljcnRjLT5zdGF0ZS0+ZXZl bnQgPSBOVUxMOwo+ICAKPiAtCQlXQVJOKCFscmV0LCAicGlwZSAlYyB2Ymxhbmsgd2FpdCB0aW1l ZCBvdXRcbiIsIHBpcGVfbmFtZShwaXBlKSk7Cj4gKwlpZiAobmVlZHNfbW9kZXNldChjcnRjLT5z dGF0ZSkgfHwgd29yay0+bmV3X2NydGNfc3RhdGUtPnVwZGF0ZV9waXBlKSB7Cj4gKwkJc3RydWN0 IGRybV9jb25uZWN0b3IgKmNvbm47Cj4gKwkJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKm9s ZF9jb25uX3N0YXRlOwo+ICsJCWludCBrID0gMDsKPiAgCj4gLQkJZHJtX2NydGNfdmJsYW5rX3B1 dChjcnRjKTsKPiAtCX0KPiArCQlqID0gMDsKPiArCj4gKwkJLyoKPiArCQkgKiBpbnRlbF91bnBp bl93b3JrX2ZuIGNhbm5vdCBkZXBlbmQgb24gdGhlIGNvbm5lY3RvciBsaXN0Cj4gKwkJICogYmVj YXVzZSBpdCBtYXkgYmUgZnJlZWQgZnJvbSB1bmRlcm5lYXRoIGl0LCBzbyBhZGQKPiArCQkgKiB0 aGVtIGFsbCB0byB0aGUgd29yayBzdHJ1Y3Qgd2hpbGUgd2UncmUgaG9sZGluZyBsb2Nrcy4KPiAr CQkgKi8KClRoYW5rcyB0byBjb25uZWN0b3IgcmVmY291bnRpbmcgbm8gbG9uZ2VyIHRydWUsIGFu ZCBhcyBsb25nIGFzIHlvdSBob2xkCm9udG8gZHJtX2F0b21pY19zdGF0ZSB0aGUgY29ubmVjdG9y cyB3aWxsIG5vIGxvbmdlciBkaXNhcHBlYXIuIFBsZWFzZQpyZXZpc2UvdXBkYXRlLgoKVGhhbmtz LCBEYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=