From: Marius Vlad Subject: Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s. Date: Fri, 27 May 2016 17:28:42 +0300 Message-ID: <20160527142842.GC10839@mcvlad-wk.rb.intel.com> References: <1464349838-9959-1-git-send-email-marius.c.vlad@intel.com> <1464349838-9959-4-git-send-email-marius.c.vlad@intel.com> <20160527115838.GD31124@nuc-i3427.alporthouse.com> <5748391F.2050307@linux.intel.com> <20160527121606.GK31124@nuc-i3427.alporthouse.com> <57483E0E.7060904@linux.intel.com> <874m9jisbf.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2088767437==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CDF36EC35 for ; Fri, 27 May 2016 14:25:05 +0000 (UTC) In-Reply-To: <874m9jisbf.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2088767437== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DSayHWYpDlRfCAAQ" Content-Disposition: inline --DSayHWYpDlRfCAAQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 27, 2016 at 03:44:20PM +0300, Mika Kuoppala wrote: > Tvrtko Ursulin writes: >=20 > > [ text/plain ] > > > > On 27/05/16 13:16, Chris Wilson wrote: > >> On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote: > >>> > >>> On 27/05/16 12:58, Chris Wilson wrote: > >>>> On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote: > >>>>> Signed-off-by: Marius Vlad > >>>> > >>>> Nak. It's a race detector. Please suggest how to increase detection > >>>> rates. > >>> > >>> As a more or less well know TV personality would say - "it's better > >>> than nothing"! :)) > >>> > >>> Seriously, under the new rules this is all we can do. Full > >>> gem-close-race will (will it?) run in the nightly run so a little > >>> bit more pain while bisecting breakages but those are the rules. We > >>> can give them a go and see how it works out. > >> > >> Wrong approach. Right approach would be to add a new test that reliably > >> detected a checklist of the most common races in under 1s. Nerfing a > >> test to make it useless makes BAT equally useless. > >> > >> So we are giving up on BAT? > > > > If it is not possible to stuff everything into the allocated budget, an= d=20 > > in cases where it may not be possible to come up with a 1s race=20 > > detector, it makes sense to move the test out of BAT and into the=20 > > nightly runs. > > >=20 > With tests to poke out races, I think the best way is to take > them out from BAT and move to nightly. Right, going to send another series with them removed if everyone agrees on this. >=20 > As A is for acceptance, it is not much value as some poor soul > will hit the race 1 month after we regressed it. >=20 > - Mika >=20 >=20 > > Agreement was that the time limits are hard limits so thats pretty much= =20 > > it. We can do this now and hit the targets and them add more tests if= =20 > > and when someone manages to implement them. > > > > I don't have a problem with that, B in BAT stands for basic anyway. > > > > We just adjust the model that when nightly test run fails someone from= =20 > > QA gets tasked with bisection etc as a top priority. > > > > Regards, > > > > Tvrtko --DSayHWYpDlRfCAAQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXSFmaAAoJELmLWIAQzyE+h8AH+wWnVAAEbWMSNLKYizamqaJh PnbpetQ8azDwBvVh4sUcPkYGLJrG4wa51xl4UVUwyAdyEmjF/boPBlSJqRq742K/ gygFmIbe/RsiS+oA9GF2LUaY0zWzbudGn9sGlNeAM1zr72DCcAadL2/84CiCUURz iEVg/K/9qM6XiNoWYYlC4rto20uz+TrsivUYpycha5/zLG7Z63iQ222Py9mY3s6m cZcyYy11TbNPL5VIqmjWZOFm4cYvEviVaOk2oJsIKjJGWL8XTb5zxyIedYTQa2dO 4Q4jVErZzFtUjMSjWpjNroO4v9JU3DzfbtQkOIqdoBcq4aSuRRWsNwKYfTjClQ8= =051P -----END PGP SIGNATURE----- --DSayHWYpDlRfCAAQ-- --===============2088767437== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============2088767437==--