From: Daniel Vetter Subject: Re: [PATCH 5/5] drm/i915: Simplify intel_init_ring_buffer prototype Date: Wed, 13 Jul 2016 14:30:58 +0200 Message-ID: <20160713123058.GK23520@phenom.ffwll.local> References: <1467391635-9902-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1467391635-9902-5-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9033F6E72D for ; Wed, 13 Jul 2016 12:31:02 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id o80so5718902wme.0 for ; Wed, 13 Jul 2016 05:31:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1467391635-9902-5-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdWwgMDEsIDIwMTYgYXQgMDU6NDc6MTVQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBFbmdpbmUgY29udGFpbnMgZGV2X3ByaXYgc28gbmVlZCB0byBwYXNzIGl0IGluLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+ CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMTggKysrKysr KystLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDEwIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5n YnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBpbmRl eCA5NjQ3NzZiYjE4MWMuLjc2MGM2YjUzZjA2MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmMKPiBAQCAtMjM3NiwyMSArMjM3NiwxOSBAQCBzdGF0aWMgdm9pZCBp bnRlbF9yaW5nX2NvbnRleHRfdW5waW4oc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwKPiAg CWk5MTVfZ2VtX2NvbnRleHRfdW5yZWZlcmVuY2UoY3R4KTsKPiAgfQo+ICAKPiAtc3RhdGljIGlu dCBpbnRlbF9pbml0X3JpbmdfYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gLQkJCQkg IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiArc3RhdGljIGludCBpbnRlbF9pbml0 X3JpbmdfYnVmZmVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgewo+IC0Jc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICsJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+ICAJc3RydWN0IGlu dGVsX3JpbmdidWZmZXIgKnJpbmdidWY7Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCVdBUk5fT04oZW5n aW5lLT5idWZmZXIpOwo+ICAKPiAtCWVuZ2luZS0+aTkxNSA9IGRldl9wcml2Owo+ICAJSU5JVF9M SVNUX0hFQUQoJmVuZ2luZS0+YWN0aXZlX2xpc3QpOwo+ICAJSU5JVF9MSVNUX0hFQUQoJmVuZ2lu ZS0+cmVxdWVzdF9saXN0KTsKPiAgCUlOSVRfTElTVF9IRUFEKCZlbmdpbmUtPmV4ZWNsaXN0X3F1 ZXVlKTsKPiAgCUlOSVRfTElTVF9IRUFEKCZlbmdpbmUtPmJ1ZmZlcnMpOwo+IC0JaTkxNV9nZW1f YmF0Y2hfcG9vbF9pbml0KGRldiwgJmVuZ2luZS0+YmF0Y2hfcG9vbCk7Cj4gKwlpOTE1X2dlbV9i YXRjaF9wb29sX2luaXQoZGV2X3ByaXYtPmRldiwgJmVuZ2luZS0+YmF0Y2hfcG9vbCk7Cj4gIAlt ZW1zZXQoZW5naW5lLT5zZW1hcGhvcmUuc3luY19zZXFubywgMCwKPiAgCSAgICAgICBzaXplb2Yo ZW5naW5lLT5zZW1hcGhvcmUuc3luY19zZXFubykpOwo+ICAKPiBAQCAtMzA5Nyw3ICszMDk1LDcg QEAgaW50IGludGVsX2luaXRfcmVuZGVyX3JpbmdfYnVmZmVyKHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSkKPiAgCQllbmdpbmUtPnNjcmF0Y2guZ3R0X29mZnNldCA9IGk5MTVfZ2VtX29i al9nZ3R0X29mZnNldChvYmopOwo+ICAJfQo+ICAKPiAtCXJldCA9IGludGVsX2luaXRfcmluZ19i dWZmZXIoZGV2X3ByaXYtPmRldiwgZW5naW5lKTsKPiArCXJldCA9IGludGVsX2luaXRfcmluZ19i dWZmZXIoZW5naW5lKTsKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gQEAgLTMx MzMsNyArMzEzMSw3IEBAIGludCBpbnRlbF9pbml0X2JzZF9yaW5nX2J1ZmZlcihzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkJCWVuZ2luZS0+aXJxX2VuYWJsZV9tYXNrID0gSTkx NV9CU0RfVVNFUl9JTlRFUlJVUFQ7Cj4gIAl9Cj4gIAo+IC0JcmV0dXJuIGludGVsX2luaXRfcmlu Z19idWZmZXIoZGV2X3ByaXYtPmRldiwgZW5naW5lKTsKPiArCXJldHVybiBpbnRlbF9pbml0X3Jp bmdfYnVmZmVyKGVuZ2luZSk7Cj4gIH0KPiAgCj4gIC8qKgo+IEBAIC0zMTQ4LDcgKzMxNDYsNyBA QCBpbnQgaW50ZWxfaW5pdF9ic2QyX3JpbmdfYnVmZmVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPiAgCj4gIAllbmdpbmUtPmZsdXNoID0gZ2VuNl9ic2RfcmluZ19mbHVzaDsKPiAg Cj4gLQlyZXR1cm4gaW50ZWxfaW5pdF9yaW5nX2J1ZmZlcihkZXZfcHJpdi0+ZGV2LCBlbmdpbmUp Owo+ICsJcmV0dXJuIGludGVsX2luaXRfcmluZ19idWZmZXIoZW5naW5lKTsKPiAgfQo+ICAKPiAg aW50IGludGVsX2luaXRfYmx0X3JpbmdfYnVmZmVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSkKPiBAQCAtMzE2Miw3ICszMTYwLDcgQEAgaW50IGludGVsX2luaXRfYmx0X3JpbmdfYnVm ZmVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCWlmIChJTlRFTF9HRU4oZGV2 X3ByaXYpIDwgOCkKPiAgCQllbmdpbmUtPmlycV9lbmFibGVfbWFzayA9IEdUX0JMVF9VU0VSX0lO VEVSUlVQVDsKPiAgCj4gLQlyZXR1cm4gaW50ZWxfaW5pdF9yaW5nX2J1ZmZlcihkZXZfcHJpdi0+ ZGV2LCBlbmdpbmUpOwo+ICsJcmV0dXJuIGludGVsX2luaXRfcmluZ19idWZmZXIoZW5naW5lKTsK PiAgfQo+ICAKPiAgaW50IGludGVsX2luaXRfdmVib3hfcmluZ19idWZmZXIoc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lKQo+IEBAIC0zMTgwLDcgKzMxNzgsNyBAQCBpbnQgaW50ZWxfaW5p dF92ZWJveF9yaW5nX2J1ZmZlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkJ ZW5naW5lLT5pcnFfcHV0ID0gaHN3X3ZlYm94X3B1dF9pcnE7Cj4gIAl9Cj4gIAo+IC0JcmV0dXJu IGludGVsX2luaXRfcmluZ19idWZmZXIoZGV2X3ByaXYtPmRldiwgZW5naW5lKTsKPiArCXJldHVy biBpbnRlbF9pbml0X3JpbmdfYnVmZmVyKGVuZ2luZSk7Cj4gIH0KPiAgCj4gIGludAo+IC0tIAo+ IDEuOS4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y YXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==