Received: from eggs.gnu.org ([2001:4830:134:3::10]:37858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBFn-0000p5-1E for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:33:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkBFg-0005qG-Fg for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:33:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBFg-0005q6-A3 for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:33:28 -0400 Date: Wed, 14 Sep 2016 16:33:25 +0200 From: Kevin Wolf Message-ID: <20160914143325.GE4649@noname.redhat.com> References: <1473088600-17930-1-git-send-email-berrange@redhat.com> <1473088600-17930-3-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1473088600-17930-3-git-send-email-berrange@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v11 2/6] option: make parse_option_bool/number non-static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Markus Armbruster , Max Reitz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > The opts-visitor.c opts_type_bool() method has code for > parsing a string to set a bool value, as does the > qemu-option.c parse_option_bool() method, except it > handles fewer cases. >=20 > To enable consistency across the codebase, extend > parse_option_bool() to handle "yes", "no", "y" and > "n", and make it non-static. Convert the opts > visitor to call this method directly. >=20 > Also make parse_option_number() non-static to allow > for similar reuse later. >=20 > Reviewed-by: Marc-Andr=E9 Lureau > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbruster > Signed-off-by: Daniel P. Berrange Reviewed-by: Kevin Wolf