Received-SPF: pass (google.com: domain of aquannie@gmail.com designates 2607:f8b0:400e:c00::243 as permitted sender) client-ip=2607:f8b0:400e:c00::243;
Date: Thu, 15 Sep 2016 01:07:48 +0530
From: Rehas Sachdeva <aquannie@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: outreachy-kernel@googlegroups.com,
	Lidza Louina <lidza.louina@gmail.com>,
	Mark Hounschell <markh@compro.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] [PATCH] staging: dgnc: Fix alignment with
 open parentheses
Message-ID: <20160914193748.GA2072@toblerone>
References: <20160914153331.GA22396@toblerone>
 <alpine.DEB.2.10.1609142111380.3347@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1609142111380.3347@hadrien>
User-Agent: Mutt/1.5.24 (2015-08-30)

On Wed, Sep 14, 2016 at 09:12:19PM +0200, Julia Lawall wrote:
> On Wed, 14 Sep 2016, Rehas Sachdeva wrote:
> 
> > This patch removes the checkpatch.pl warning:
> > CHECK: Alignment should match open parenthesis.
> >
> > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> > ---
> >  drivers/staging/dgnc/dgnc_tty.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> > index 31b18e6..75e0a6b 100644
> > --- a/drivers/staging/dgnc/dgnc_tty.c
> > +++ b/drivers/staging/dgnc/dgnc_tty.c
> > @@ -1037,8 +1037,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
> >  	 * ch_flags_wait to wake us back up.
> >  	 */
> >  	rc = wait_event_interruptible(ch->ch_flags_wait,
> > -		(((ch->ch_tun.un_flags | ch->ch_pun.un_flags) &
> > -		  UN_CLOSING) == 0));
> > +				      (((ch->ch_tun.un_flags |
> > +					 ch->ch_pun.un_flags) &
> > +					UN_CLOSING) == 0));
> 
> Bother are not so nice, but maybe it was better before.  It's nice to have
> at least both arguments to | on the same line.
> 
> julia
>

Alright. I'll keep that in mind.

Thanks

Rehas

> >
> >  	/* If ret is non-zero, user ctrl-c'ed us */
> >  	if (rc)
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914153331.GA22396%40toblerone.
> > For more options, visit https://groups.google.com/d/optout.
> >