Received: from eggs.gnu.org ([2001:4830:134:3::10]:47990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkXiL-0005YG-4g for qemu-devel@nongnu.org; Thu, 15 Sep 2016 10:32:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkXiG-0004rn-G1 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 10:32:33 -0400 Received: from victor.provo.novell.com ([137.65.250.26]:60113 helo=prv3-mh.provo.novell.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkXiG-0004rH-7W for qemu-devel@nongnu.org; Thu, 15 Sep 2016 10:32:28 -0400 From: Lin Ma Date: Thu, 15 Sep 2016 22:31:58 +0800 Message-Id: <20160915143158.4796-1-lma@suse.com> Subject: [Qemu-devel] [PATCH] msmouse: Fix segfault caused by free the chr before chardev cleanup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, pbonzini@redhat.com Cc: marcandre.lureau@redhat.com Segfault happens when leaving qemu with msmouse backend: #0 0x00007fa8526ac975 in raise () at /lib64/libc.so.6 #1 0x00007fa8526add8a in abort () at /lib64/libc.so.6 #2 0x0000558be78846ab in error_exit (err=16, msg=0x558be799da10 ... #3 0x0000558be7884717 in qemu_mutex_destroy (mutex=0x558be93be750) at ... #4 0x0000558be7549951 in qemu_chr_free_common (chr=0x558be93be750) at ... #5 0x0000558be754999c in qemu_chr_free (chr=0x558be93be750) at ... #6 0x0000558be7549a20 in qemu_chr_delete (chr=0x558be93be750) at ... #7 0x0000558be754a8ef in qemu_chr_cleanup () at qemu-char.c:4643 #8 0x0000558be755843e in main (argc=5, argv=0x7ffe925d7118, ... The chr was freed by msmouse close callback before chardev cleanup, Then qemu_mutex_destroy triggered raise(). Because freeing chr is handled by qemu_chr_free_common, Remove the free from msmouse_chr_close to avoid double free. Signed-off-by: Lin Ma --- backends/msmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/backends/msmouse.c b/backends/msmouse.c index aeb9055..7690c42 100644 --- a/backends/msmouse.c +++ b/backends/msmouse.c @@ -139,7 +139,6 @@ static void msmouse_chr_close (struct CharDriverState *chr) qemu_input_handler_unregister(mouse->hs); g_free(mouse); - g_free(chr); } static QemuInputHandler msmouse_handler = { -- 2.9.2