Received: from eggs.gnu.org ([2001:4830:134:3::10]:53096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnNjV-0008AK-1J for qemu-devel@nongnu.org; Fri, 23 Sep 2016 06:29:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnNjR-00036t-Nz for qemu-devel@nongnu.org; Fri, 23 Sep 2016 06:29:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnNjR-00036i-II for qemu-devel@nongnu.org; Fri, 23 Sep 2016 06:29:25 -0400 Date: Fri, 23 Sep 2016 12:29:21 +0200 From: Kevin Wolf Message-ID: <20160923102921.GE5436@noname.redhat.com> References: <1474286310-6922-1-git-send-email-berrange@redhat.com> <1474286310-6922-7-git-send-email-berrange@redhat.com> <20160919121211.GN15201@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160919121211.GN15201@redhat.com> Subject: Re: [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Markus Armbruster , Max Reitz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= Am 19.09.2016 um 14:12 hat Daniel P. Berrange geschrieben: > On Mon, Sep 19, 2016 at 12:58:30PM +0100, Daniel P. Berrange wrote: > > Fortunately there is no existing object that implements > > the UserCreatable interface that relies on the list > > handling behaviour, so it is possible to swap out the > > OptsVisitor for a different visitor implementation, so > > -object supports non-scalar properties, thus leaving > > other users of OptsVisitor unaffected. > > Urgh, I've just discovered that this is not in fact true. > > The 'memory-backend' object type uses uint16List which > has the hacky list syntax > > -object memory-backend-ram,\ > id=ram-node2,size=24578621440,policy=bind,\ > host-nodes=1-2,host-nodes=5,host-nodes=7, > > So I'll need to figure out a way to preserve this syntax... If this turns out rather hard, would it make sense to merge just patches 1 to 5 for now to enable -blockdev, which doesn't need this syntax? Then you can add the magic list syntax as a follow-up together with the -object work. Kevin