Received: from eggs.gnu.org ([2001:4830:134:3::10]:54306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnRMA-00031a-92 for qemu-devel@nongnu.org; Fri, 23 Sep 2016 10:21:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnRM6-0002m0-He for qemu-devel@nongnu.org; Fri, 23 Sep 2016 10:21:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnRM6-0002lZ-Ar for qemu-devel@nongnu.org; Fri, 23 Sep 2016 10:21:34 -0400 Date: Fri, 23 Sep 2016 15:21:29 +0100 From: "Daniel P. Berrange" Message-ID: <20160923142129.GJ29098@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474286310-6922-1-git-send-email-berrange@redhat.com> <1474286310-6922-3-git-send-email-berrange@redhat.com> <20160923102430.GD5436@noname.redhat.com> <20160923110756.GF29098@redhat.com> <42635a63-5e76-4305-cf70-1799b55ff094@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <42635a63-5e76-4305-cf70-1799b55ff094@redhat.com> Subject: Re: [Qemu-devel] [PATCH v13 2/6] option: make parse_option_bool/number non-static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= On Fri, Sep 23, 2016 at 09:16:35AM -0500, Eric Blake wrote: > On 09/23/2016 06:07 AM, Daniel P. Berrange wrote: > > >>> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, > >>> - name, "'on' or 'off'"); > >>> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name, > >>> + "on|yes|y|off|no|n"); > >> > >> This change requires an update to the reference output of some > >> qemu-iotests (at least 051 and 137). > > > > Opps, yes, so it does. > > Do any of the docker tests or buildbots catch this automatically? (I > often forget to run qemu-iotests, since they are not part of 'make check') FWIW, as mentioned here: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg04392.html I've tried adding qemu-iotests to our travis config for raw, qcow2 and luks, but hit many non-deterministic failures in it. We'll have to get it stable under high load before we can have it run automatically unless we want high false-failure rate. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|