Return-Path: Received: from mail-oi0-x241.google.com (mail-oi0-x241.google.com [IPv6:2607:f8b0:4003:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3st0fd4z7yzDrbq for ; Tue, 11 Oct 2016 00:03:05 +1100 (AEDT) Received: by mail-oi0-x241.google.com with SMTP id e12so1232857oib.3 for ; Mon, 10 Oct 2016 06:03:05 -0700 (PDT) Sender: Tejun Heo Date: Mon, 10 Oct 2016 09:02:53 -0400 From: Tejun Heo To: Michael Ellerman Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, kernel-team@fb.com, "linuxppc-dev@lists.ozlabs.org" Subject: Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Message-ID: <20161010130253.GB29742@mtj.duckdns.org> References: <1473967821-24363-1-git-send-email-tj@kernel.org> <1473967821-24363-2-git-send-email-tj@kernel.org> <20160917172314.GB10771@mtj.duckdns.org> <87twck5wqo.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <87twck5wqo.fsf@concordia.ellerman.id.au> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello, Michael. On Mon, Oct 10, 2016 at 09:22:55PM +1100, Michael Ellerman wrote: > This patch seems to be causing one of my Power8 boxes not to boot. > > Specifically commit 3347fa092821 ("workqueue: make workqueue available > early during boot") in linux-next. > > If I revert this on top of next-20161005 then the machine boots again. > > I've attached the oops below. It looks like the cfs_rq of p->se is NULL? Hah, weird that it's arch dependent, or maybe it's just different config options. Most likely, it's caused by workqueue_init() call being moved too early. Can you please try the following patch and see whether the problem goes away? Thanks. diff --git a/init/main.c b/init/main.c index 5c4fd68..fe4fa47 100644 --- a/init/main.c +++ b/init/main.c @@ -1013,7 +1013,7 @@ static noinline void __init kernel_init_freeable(void) smp_prepare_cpus(setup_max_cpus); - workqueue_init(); + //workqueue_init(); do_pre_smp_initcalls(); lockup_detector_init(); diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ad0cd43..400f5e2 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5585,3 +5585,4 @@ int __init workqueue_init(void) return 0; } +early_initcall(workqueue_init);